[GitHub] carbondata pull request #1126: [CARBONDATA-1258] CarbonData should not allow...

[qiuchenjian-2]

Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1126#discussion_r157729475
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/DateDirectDictionaryGenerator.java ---
    @@ -42,12 +42,37 @@
     
       private String dateFormat;
     
    +  /**
    +   * min value supported for date type column
    +   */
    +  private static final long MIN_VALUE;
    +  /**
    +   * MAx value supported for date type column
    +   */
    +  private static final long MAX_VALUE;
       /**
        * Logger instance
        */
       private static final LogService LOGGER =
           LogServiceFactory.getLogService(DateDirectDictionaryGenerator.class.getName());
     
    +  static {
    +    SimpleDateFormat df = new SimpleDateFormat("yyyy-MM-dd");
    +    df.setTimeZone(TimeZone.getTimeZone("GMT"));
    +    long minValue = 0;
    +    long maxValue = 0;
    +    try {
    +      minValue = df.parse("0001-01-01").getTime();
    +      maxValue = df.parse("9999-12-31").getTime();
    +    } catch (ParseException e) {
    --- End diff --
   
    Fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2132/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2414/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    retest this please


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    retest this please


---

[qiuchenjian-2]

Github user mohammadshahidkhan commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/982/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2205/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1126
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1126


---