[GitHub] carbondata pull request #1159: [CARBONDATA-1274] added example for update an...

[qiuchenjian-2]

GitHub user mayunSaicmotor opened a pull request:

    https://github.com/apache/carbondata/pull/1159

    [CARBONDATA-1274] added example for update and delete

    added detailed examples for update and delete in spark 2.1 and spark1.6


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-1274-NEW

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1159
   
----
commit f93fbbfa02db6191a5f7081a33a8992598b0b77e
Author: mayun <[hidden email]>
Date:   2017-07-11T14:56:10Z

    add update and delete examples

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3023/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/435/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1159#discussion_r126856684
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala ---
    @@ -0,0 +1,183 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +object DataUpdateDeleteExample {
    +
    +  def main(args: Array[String]) {
    +
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +
    +    var hdfsStoreFlg = false;
    +    if (args != null && args.size > 0) {
    +      if ("true".equalsIgnoreCase(args(0))) {
    +        hdfsStoreFlg = true
    +      }
    +    }
    +    var storeLocation = s"$rootPath/examples/spark2/target/store"
    +    var warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    var metastoredb = s"$rootPath/examples/spark2/target"
    +    var testData = s"$rootPath/examples/spark2/src/main/resources/data_update.csv"
    +    if (hdfsStoreFlg) {
    +      storeLocation = "hdfs://nameservice1/carbon2/data/"
    +      warehouse = "hdfs://nameservice1/carbon2/warehouse/"
    +      metastoredb = "hdfs://nameservice1/carbon2/carbonstore/"
    +      testData = "hdfs://nameservice1/carbon2/data_update.csv"
    +    }
    +
    +    import org.apache.spark.sql.CarbonSession._
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("CarbonSessionExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .config("spark.driver.host", "localhost")
    +      .config("spark.sql.crossJoin.enabled", "true")
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +    spark.sparkContext.setLogLevel("WARN")
    +
    +    // Specify date format based on raw data
    +    CarbonProperties.getInstance()
    +      .addProperty(CarbonCommonConstants.CARBON_DATE_FORMAT, "yyyy/MM/dd")
    +
    +    import spark.implicits._
    +    // Drop table
    +    spark.sql("DROP TABLE IF EXISTS update_table")
    +    spark.sql("DROP TABLE IF EXISTS big_table")
    +
    +    spark.sql(s"""
    +           CREATE TABLE IF NOT EXISTS update_table
    +           (ID Int, country String,
    +           name String, phonetype String, serialname char(10), salary Int)
    +           STORED BY 'carbondata'
    +           """)
    +
    +    spark.sql(s"""
    +           LOAD DATA LOCAL INPATH '$testData' INTO TABLE update_table
    +           """)
    +
    +    val df = spark.sparkContext.parallelize(1 to 2000000)
    +      .map(x => (x, "name" + (1000000 + x), "2017/07/" + (x % 20 + 1),
    +        "china", 2 * x))
    +      .toDF("id", "name", "date", "country", "salary")
    +    df.write
    +      .format("carbondata")
    +      .option("tableName", "big_table")
    +      .option("tempCSV", "true")
    +      .option("compress", "true")
    +      .mode(SaveMode.Overwrite)
    +      .save()
    +
    +    // loop update and delete in big_table
    +    var loopCnt = 5
    +    for (index <- 1 to loopCnt) {
    +      // Update country with simple SET
    +      var name = "name" + (1200000 + index)
    +      spark.sql(s"""
    +           UPDATE big_table SET (country) = ('india') WHERE name = '$name'
    +           """).show()
    +      // Query data after the above update
    +      spark.sql(s"""
    +           SELECT * FROM big_table WHERE name = '$name'
    +           """).show()
    +
    +      // Update date with simple SET
    +      name = "name" + (1200000 + loopCnt + index)
    +      spark.sql(s"""
    +           UPDATE big_table SET (date) = ('2018/08/08') WHERE name = '$name'
    +           """).show()
    +      // Query data after the above update
    +      spark.sql(s"""
    +           SELECT * FROM big_table WHERE name = '$name'
    +           """).show()
    +
    +      // Update salary with simple SET
    +      name = "name" + (1200000 + loopCnt * 2 + index)
    +      spark.sql(s"""
    +           UPDATE big_table SET (salary) = (9999999) WHERE name = '$name'
    +           """).show()
    +      // Query data after the above update
    +      spark.sql(s"""
    +           SELECT * FROM big_table WHERE name = '$name'
    +           """).show()
    +
    +      // Update data with subquery result SET
    +      var id = loopCnt + index
    +      spark.sql(s"""
    +         UPDATE big_table
    +         SET (big_table.country, big_table.name) = (SELECT u.country,
    +          u.name FROM update_table u WHERE u.id = $index)
    +         WHERE big_table.id < $id""").show()
    +      // Query data after the above update
    +      spark.sql(s"""
    +           SELECT * FROM big_table where big_table.id < $id
    +           """).show()
    +
    +      // Update data with join query result SET
    +      id = 2000000 - index * 10
    +      val id1 = loopCnt * 3 + index
    +      val id2 = loopCnt * 4 + index
    +      spark.sql(s"""
    +         UPDATE big_table
    +         SET (big_table.country, big_table.salary) =
    +         (SELECT u.country, f.salary FROM update_table u FULL JOIN update_table f
    +         WHERE u.id = $id1  and f.id=$id2) WHERE big_table.id > $id""").show()
    +      // Query data after the above update
    +      spark.sql(s"""
    +           SELECT * FROM big_table where big_table.id < $id
    +           """).show()
    +
    +      // delete by name
    +      name = "name" + (1200000 + loopCnt * 3 + index)
    +      spark.sql(s"""
    +           DELETE FROM big_table WHERE name = '$name'
    +           """).show()
    +      // Query data after the above delete
    +      spark.sql(s"""
    +           SELECT * FROM big_table WHERE name = '$name'
    +           """).show()
    +
    +      // delete by salary
    +      var salary = 2000000*2 - index * 4
    +      spark.sql(s"""
    +           DELETE FROM big_table WHERE salary > $salary and salary < 9999999
    +           """).show()
    +      spark.sql(s"""
    +           SELECT * FROM big_table WHERE salary > $salary and salary < 9999999
    +           """).show()
    +    }
    +
    +    spark.sql(s"""
    +           SELECT count(*) FROM big_table
    +           """).show()
    +
    +    // Drop table
    +    spark.sql("DROP TABLE IF EXISTS update_table")
    +    spark.sql("DROP TABLE IF EXISTS big_table")
    +  }
    --- End diff --
   
    please add spark.stop()  at the end.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    @mayunSaicmotor  Please change PR title to : Adds example for update and delete with Spark 2.1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    @chenliang613 @mayunSaicmotor pr is already raised for this issue https://github.com/apache/carbondata/pull/1158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    @mayunSaicmotor  In the future, to avoid conflict , please assign JIRA to yourself if you plan to work on this PR.
    @anubhav100  my side is very appreciating your effort, thanks for your contribution. But mayun is creating this example which would cover all actual use cases.  so can you please close your PR.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    @chenliang613 sure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1159#discussion_r126909663
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala ---
    @@ -0,0 +1,183 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +object DataUpdateDeleteExample {
    +
    +  def main(args: Array[String]) {
    +
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +
    +    var hdfsStoreFlg = false;
    +    if (args != null && args.size > 0) {
    +      if ("true".equalsIgnoreCase(args(0))) {
    +        hdfsStoreFlg = true
    +      }
    +    }
    +    var storeLocation = s"$rootPath/examples/spark2/target/store"
    +    var warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    var metastoredb = s"$rootPath/examples/spark2/target"
    +    var testData = s"$rootPath/examples/spark2/src/main/resources/data_update.csv"
    +    if (hdfsStoreFlg) {
    +      storeLocation = "hdfs://nameservice1/carbon2/data/"
    +      warehouse = "hdfs://nameservice1/carbon2/warehouse/"
    +      metastoredb = "hdfs://nameservice1/carbon2/carbonstore/"
    +      testData = "hdfs://nameservice1/carbon2/data_update.csv"
    +    }
    +
    +    import org.apache.spark.sql.CarbonSession._
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("CarbonSessionExample")
    --- End diff --
   
    correct the app name from carbonsession example to DataUpdateDeleteExample


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user mayunSaicmotor commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1159#discussion_r127007813
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala ---
    @@ -0,0 +1,183 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +object DataUpdateDeleteExample {
    +
    +  def main(args: Array[String]) {
    +
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +
    +    var hdfsStoreFlg = false;
    +    if (args != null && args.size > 0) {
    +      if ("true".equalsIgnoreCase(args(0))) {
    +        hdfsStoreFlg = true
    +      }
    +    }
    +    var storeLocation = s"$rootPath/examples/spark2/target/store"
    +    var warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    var metastoredb = s"$rootPath/examples/spark2/target"
    +    var testData = s"$rootPath/examples/spark2/src/main/resources/data_update.csv"
    +    if (hdfsStoreFlg) {
    +      storeLocation = "hdfs://nameservice1/carbon2/data/"
    +      warehouse = "hdfs://nameservice1/carbon2/warehouse/"
    +      metastoredb = "hdfs://nameservice1/carbon2/carbonstore/"
    +      testData = "hdfs://nameservice1/carbon2/data_update.csv"
    +    }
    +
    +    import org.apache.spark.sql.CarbonSession._
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("CarbonSessionExample")
    --- End diff --
   
    fixed  thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3054/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/466/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3055/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3057/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1159
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/468/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1159#discussion_r127111519
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala ---
    @@ -0,0 +1,173 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +import java.text.SimpleDateFormat
    +
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +object DataUpdateDeleteExample {
    +
    +  def main(args: Array[String]) {
    +
    +    // for local files
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +    // for hdfs files
    +    // var rootPath = "hdfs://hdfs-host/carbon"
    +
    +    var storeLocation = s"$rootPath/examples/spark2/target/store"
    +    var warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    var metastoredb = s"$rootPath/examples/spark2/target"
    +
    +    import org.apache.spark.sql.CarbonSession._
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("DataUpdateDeleteExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .config("spark.driver.host", "localhost")
    +      .config("spark.sql.crossJoin.enabled", "true")
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +    spark.sparkContext.setLogLevel("WARN")
    +
    +    // Specify date format based on raw data
    +    CarbonProperties.getInstance()
    +      .addProperty(CarbonCommonConstants.CARBON_DATE_FORMAT, "yyyy-MM-dd")
    +
    +    import spark.implicits._
    +    // Drop table
    +    spark.sql("DROP TABLE IF EXISTS t3")
    +    spark.sql("DROP TABLE IF EXISTS t5")
    +
    +    // use code to create table t5 and insert data
    +    var sdf = new SimpleDateFormat("yyyy-MM-dd")
    +    var df = spark.sparkContext.parallelize(1 to 10)
    +      .map(x => (x, new java.sql.Date(sdf.parse("2015-07-" + (x % 10 + 10)).getTime),
    +        "china", "aaa" + x, "phone" + 555 * x, "ASD" + (60000 + x), 14999 + x))
    +      .toDF("ID", "date", "country", "name", "phonetype", "serialname", "salary")
    +    df.write
    +      .format("carbondata")
    +      .option("tableName", "t3")
    +      .option("tempCSV", "true")
    +      .option("compress", "true")
    +      .mode(SaveMode.Overwrite)
    +      .save()
    +
    +    sdf = new SimpleDateFormat("yyyy-MM-dd")
    --- End diff --
   
    Why creates two "sdf" for new SimpleDataFormat, (row 64 and row 77)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1159#discussion_r127112225
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala ---
    @@ -0,0 +1,173 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +import java.text.SimpleDateFormat
    +
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +object DataUpdateDeleteExample {
    +
    +  def main(args: Array[String]) {
    +
    +    // for local files
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +    // for hdfs files
    +    // var rootPath = "hdfs://hdfs-host/carbon"
    +
    +    var storeLocation = s"$rootPath/examples/spark2/target/store"
    +    var warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    var metastoredb = s"$rootPath/examples/spark2/target"
    +
    +    import org.apache.spark.sql.CarbonSession._
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("DataUpdateDeleteExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .config("spark.driver.host", "localhost")
    +      .config("spark.sql.crossJoin.enabled", "true")
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +    spark.sparkContext.setLogLevel("WARN")
    +
    +    // Specify date format based on raw data
    +    CarbonProperties.getInstance()
    +      .addProperty(CarbonCommonConstants.CARBON_DATE_FORMAT, "yyyy-MM-dd")
    +
    +    import spark.implicits._
    +    // Drop table
    +    spark.sql("DROP TABLE IF EXISTS t3")
    +    spark.sql("DROP TABLE IF EXISTS t5")
    +
    +    // use code to create table t5 and insert data
    +    var sdf = new SimpleDateFormat("yyyy-MM-dd")
    +    var df = spark.sparkContext.parallelize(1 to 10)
    +      .map(x => (x, new java.sql.Date(sdf.parse("2015-07-" + (x % 10 + 10)).getTime),
    +        "china", "aaa" + x, "phone" + 555 * x, "ASD" + (60000 + x), 14999 + x))
    +      .toDF("ID", "date", "country", "name", "phonetype", "serialname", "salary")
    +    df.write
    +      .format("carbondata")
    +      .option("tableName", "t3")
    +      .option("tempCSV", "true")
    +      .option("compress", "true")
    +      .mode(SaveMode.Overwrite)
    +      .save()
    +
    +    sdf = new SimpleDateFormat("yyyy-MM-dd")
    +    df = spark.sparkContext.parallelize(1 to 10)
    +      .map(x => (x, new java.sql.Date(sdf.parse("2017-07-" + (x % 20 + 1)).getTime),
    +        "usa", "bbb" + x, "phone" + 100 * x, "ASD" + (1000 * x - x), 25000 + x))
    +      .toDF("ID", "date", "country", "name", "phonetype", "serialname", "salary")
    --- End diff --
   
    To easier identify data from different table, please change as below :
    toDF("t5.ID", "t5.date", "t5.country", "t5.name", "t5.phonetype", "t5.serialname", "t5.salary")


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1159#discussion_r127112410
 
    --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/DataUpdateDeleteExample.scala ---
    @@ -0,0 +1,173 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.examples
    +
    +import java.io.File
    +import java.text.SimpleDateFormat
    +
    +import org.apache.spark.sql.SaveMode
    +import org.apache.spark.sql.SparkSession
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +object DataUpdateDeleteExample {
    +
    +  def main(args: Array[String]) {
    +
    +    // for local files
    +    val rootPath = new File(this.getClass.getResource("/").getPath
    +      + "../../../..").getCanonicalPath
    +    // for hdfs files
    +    // var rootPath = "hdfs://hdfs-host/carbon"
    +
    +    var storeLocation = s"$rootPath/examples/spark2/target/store"
    +    var warehouse = s"$rootPath/examples/spark2/target/warehouse"
    +    var metastoredb = s"$rootPath/examples/spark2/target"
    +
    +    import org.apache.spark.sql.CarbonSession._
    +    val spark = SparkSession
    +      .builder()
    +      .master("local")
    +      .appName("DataUpdateDeleteExample")
    +      .config("spark.sql.warehouse.dir", warehouse)
    +      .config("spark.driver.host", "localhost")
    +      .config("spark.sql.crossJoin.enabled", "true")
    +      .getOrCreateCarbonSession(storeLocation, metastoredb)
    +    spark.sparkContext.setLogLevel("WARN")
    +
    +    // Specify date format based on raw data
    +    CarbonProperties.getInstance()
    +      .addProperty(CarbonCommonConstants.CARBON_DATE_FORMAT, "yyyy-MM-dd")
    +
    +    import spark.implicits._
    +    // Drop table
    +    spark.sql("DROP TABLE IF EXISTS t3")
    +    spark.sql("DROP TABLE IF EXISTS t5")
    +
    +    // use code to create table t5 and insert data
    +    var sdf = new SimpleDateFormat("yyyy-MM-dd")
    +    var df = spark.sparkContext.parallelize(1 to 10)
    +      .map(x => (x, new java.sql.Date(sdf.parse("2015-07-" + (x % 10 + 10)).getTime),
    +        "china", "aaa" + x, "phone" + 555 * x, "ASD" + (60000 + x), 14999 + x))
    +      .toDF("ID", "date", "country", "name", "phonetype", "serialname", "salary")
    +    df.write
    +      .format("carbondata")
    +      .option("tableName", "t3")
    +      .option("tempCSV", "true")
    +      .option("compress", "true")
    +      .mode(SaveMode.Overwrite)
    +      .save()
    +
    +    sdf = new SimpleDateFormat("yyyy-MM-dd")
    +    df = spark.sparkContext.parallelize(1 to 10)
    +      .map(x => (x, new java.sql.Date(sdf.parse("2017-07-" + (x % 20 + 1)).getTime),
    +        "usa", "bbb" + x, "phone" + 100 * x, "ASD" + (1000 * x - x), 25000 + x))
    +      .toDF("ID", "date", "country", "name", "phonetype", "serialname", "salary")
    +    df.write
    +      .format("carbondata")
    +      .option("tableName", "t5")
    +      .option("tempCSV", "true")
    +      .option("compress", "true")
    +      .mode(SaveMode.Overwrite)
    +      .save()
    +
    +    // Query data again after the above data insert
    --- End diff --
   
    please optimize the comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---