[GitHub] carbondata pull request #1178: [WIP]Added tableProvider to supply carbonTabl...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1178
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/514/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1178
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3105/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1178#discussion_r127924842
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/TableSegmentUniqueIdentifier.java ---
    @@ -34,6 +36,8 @@
        */
       private AbsoluteTableIdentifier absoluteTableIdentifier;
     
    +  private TableProvider tableProvider;
    --- End diff --
   
    Keep table provider out of TableSegmentUniqueIdentifier, logically it does not belong here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1178#discussion_r127925159
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/IncrementalColumnDictionaryGenerator.java ---
    @@ -113,20 +115,21 @@ public IncrementalColumnDictionaryGenerator(CarbonDimension dimension, int maxVa
         // initialize params
         CarbonMetadata metadata = CarbonMetadata.getInstance();
         CarbonTable carbonTable = metadata.getCarbonTable(tableUniqueName);
    +    TableProvider tableProvider = new SingleTableProvider(carbonTable);
         CarbonTableIdentifier tableIdentifier = carbonTable.getCarbonTableIdentifier();
         ColumnIdentifier columnIdentifier = dimension.getColumnIdentifier();
         String storePath = carbonTable.getStorePath();
         DictionaryService dictionaryService = CarbonCommonFactory.getDictionaryService();
         // create dictionary cache from dictionary File
         DictionaryColumnUniqueIdentifier identifier =
    -            new DictionaryColumnUniqueIdentifier(tableIdentifier, columnIdentifier,
    -                    columnIdentifier.getDataType());
    +        new DictionaryColumnUniqueIdentifier(tableIdentifier, columnIdentifier,
    +            columnIdentifier.getDataType(), tableProvider);
         Boolean isDictExists = CarbonUtil.isFileExistsForGivenColumn(storePath, identifier);
         Dictionary dictionary = null;
         long t1 = System.currentTimeMillis();
         if (isDictExists) {
    -      Cache<DictionaryColumnUniqueIdentifier, Dictionary> dictCache = CacheProvider.getInstance()
    -              .createCache(CacheType.REVERSE_DICTIONARY, storePath);
    +      Cache<DictionaryColumnUniqueIdentifier, Dictionary> dictCache =
    --- End diff --
   
    Remove all indentation changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1178#discussion_r127925308
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/AbsoluteTableIdentifier.java ---
    @@ -47,13 +48,24 @@
        */
       private CarbonTableIdentifier carbonTableIdentifier;
     
    +  private TableProvider tableProvider;
    --- End diff --
   
    Locally it should not belong here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user dhatchayani closed the pull request at:

    https://github.com/apache/carbondata/pull/1178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---