[GitHub] carbondata pull request #1190: [CARBONDATA-1323] Presto Optimization for Int...

[qiuchenjian-2]

GitHub user bhavya411 opened a pull request:

    https://github.com/apache/carbondata/pull/1190

    [CARBONDATA-1323] Presto Optimization for Integration Layer

    Changes done to increase the performance of Presto Integration
    - Removed Extra loops to save time on Object creation
    - Implemented Lazy Blocks so that data in block in not initialized in first go.
    - Implemented a new efficient dictionary decoder.
   
    Build is verified
    All test cases passing
    Manually verified the data

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bhavya411/incubator-carbondata CARBONDATA-1323

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1190
   
----
commit fc05a55a26b47edc5799f5ab042b83534b1475b0
Author: Bhavya Aggarwal <[hidden email]>
Date:   2017-07-21T07:36:46Z

    Presto Optimization

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1190
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1190
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1190
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/575/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1190
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3170/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1190#discussion_r129528008
 
    --- Diff: integration/presto/pom.xml ---
    @@ -228,6 +228,33 @@
                 <skip>true</skip>
               </configuration>
             </plugin>
    +        <plugin>
    +          <groupId>org.scala-tools</groupId>
    +          <artifactId>maven-scala-plugin</artifactId>
    --- End diff --
   
    can you explain, why need add the plugin to pom file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user bhavya411 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1190#discussion_r129588108
 
    --- Diff: integration/presto/pom.xml ---
    @@ -228,6 +228,33 @@
                 <skip>true</skip>
               </configuration>
             </plugin>
    +        <plugin>
    +          <groupId>org.scala-tools</groupId>
    +          <artifactId>maven-scala-plugin</artifactId>
    --- End diff --
   
    I have written the dictionary decoding in scala as it is more optimized and easier to understand, hence we have to add this plugin for compiling the scala code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1190


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---