[GitHub] carbondata pull request #1231: CARBONDATA-1359 Unable to use carbondata on h...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1231
 
    SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/211/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1231#discussion_r133666819
 
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java ---
    @@ -94,20 +94,21 @@ private static void populateCarbonTable(Configuration configuration, String path
         } else {
           if (paths != null) {
             for (String inputPath : inputPaths) {
    -          if (paths.startsWith(inputPath)) {
    +          if (paths.startsWith(inputPath.replace("file:", ""))) {
                 validInputPath = inputPath;
                 break;
               }
             }
           }
         }
    -    AbsoluteTableIdentifier absoluteTableIdentifier =
    -        AbsoluteTableIdentifier.fromTablePath(validInputPath);
    -    // read the schema file to get the absoluteTableIdentifier having the correct table id
    -    // persisted in the schema
    -    CarbonTable carbonTable = SchemaReader.readCarbonTableFromStore(absoluteTableIdentifier);
    -    setTableInfo(configuration, carbonTable.getTableInfo());
    -  }
    +      AbsoluteTableIdentifier absoluteTableIdentifier =
    +              AbsoluteTableIdentifier.fromTablePath(validInputPath);
    +      // read the schema file to get the absoluteTableIdentifier having the correct table id
    --- End diff --
   
    This part code has some code style issue, please fix it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1231
 
    @shivangi1015  as you provided steps, i verified it , it is working fine, thank you fixed this issue.
    Please check CI, there are some code check style issues, please fix it, as below :
    /home/jenkins/jenkins-slave/workspace/carbondata-pr-spark-2.1/integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java:104: error: 'member def type' have incorrect indentation level 6, expected level should be 4.
    /home/jenkins/jenkins-slave/workspace/carbondata-pr-spark-2.1/integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java:104: error: 'method def' child have incorrect indentation level 6, expected level should be 4.
    /home/jenkins/jenkins-slave/workspace/carbondata-pr-spark-2.1/integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java:108: error: 'member def type' have incorrect indentation level 6, expected level should be 4.
    /home/jenkins/jenkins-slave/workspace/carbondata-pr-spark-2.1/integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java:108: error: 'method def' child have incorrect indentation level 6, expected level should be 4.
    /home/jenkins/jenkins-slave/workspace/carbondata-pr-spark-2.1/integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java:109: error: 'method def' child have incorrect indentation level 6, expected level should be 4.
    /home/jenkins/jenkins-slave/workspace/carbondata-pr-spark-2.1/integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java:110: error: 'method def' child have incorrect indentation level 6, expected level should be 4.
    /home/jenkins/jenkins-slave/workspace/carbondata-pr-spark-2.1/integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java:111: error: 'method def rcurly' have incorrect indentation level 4, expected level should be 2.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1231
 
    LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1231


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1231
 
    SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/215/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---