[GitHub] carbondata pull request #1234: fix bug in Spi2CarbondataTypeMapper method, i...

[qiuchenjian-2]

GitHub user linqer opened a pull request:

    https://github.com/apache/carbondata/pull/1234

    fix bug in Spi2CarbondataTypeMapper method, it will cause exception like

    com.facebook.presto.spi.PrestoException: DECIMAL precision must be in range [1, 38]
             at com.facebook.presto.spi.type.DecimalType.validatePrecisionScale(DecimalType.java:94)
             at com.facebook.presto.spi.type.ShortDecimalType.<init>(ShortDecimalType.java:34)
             at com.facebook.presto.spi.type.DecimalType.createDecimalType(DecimalType.java:37)
             at org.apache.carbondata.presto.CarbondataRecordSetProvider.Spi2CarbondataTypeMapper(CarbondataRecordSetProvider.java:257)
   
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
   
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
     - [ ] Testing done
     
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - What manual testing you have done?
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/linqer/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1234
   
----
commit 7ff11cbd2e9d22240cf8894da2ee2cf8ff4314e7
Author: linqer.li <[hidden email]>
Date:   2017-08-02T08:15:01Z

    fix bug in Spi2CarbondataTypeMapper method, it will cause exception like
   
    com.facebook.presto.spi.PrestoException: DECIMAL precision must be in range [1, 38]
             at com.facebook.presto.spi.type.DecimalType.validatePrecisionScale(DecimalType.java:94)
             at com.facebook.presto.spi.type.ShortDecimalType.<init>(ShortDecimalType.java:34)
             at com.facebook.presto.spi.type.DecimalType.createDecimalType(DecimalType.java:37)
             at org.apache.carbondata.presto.CarbondataRecordSetProvider.Spi2CarbondataTypeMapper(CarbondataRecordSetProvider.java:257)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    add to whitelist


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3378/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/781/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/108/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user linqer commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Please note that: In addition to solving the bug " DECIMAL precision must be in range ", another modification has been made, there is one bit incompatible:
   
    1. When converting carbondata type to presto type,  if the type is uncertain, original code will convert it to the Presto String type. Now an Unsupport exception will be throw out,
    ( CarbondataMetadata.CarbondataType2SpiMapper is changed to  CarbondataType.getSpiType）
   
    2. When converting presto type to carbondata type,  if the type is uncertain, original code will convert it to the Carbon String type. Now an Unsupport exception will be throw out,
    （CarbondataRecordSetProvider.Spi2CarbondataTypeMapper  is changed to CarbondataType.toCarbonType）



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/810/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    SDV Build Failed with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/136/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3409/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user linqer commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    now I should close this pull requests? and will some one merge the code change to master branch ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    @linqer how to test this pr can you provide reproducable steps?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    @linqer please correct your PR title as per : https://github.com/apache/carbondata/blob/master/docs/How-to-contribute-to-Apache-CarbonData.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user linqer commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    Table Script：
    carbon.sql("create table nation ( n_nationkey int, n_name string, n_regionkey int, n_comment string ) stored by 'carbondata'")
   
    The lastest master branch:
    sql: select * from nation where n_name='ALGERIA';
   
    2017-08-17T14:17:07.675+0800 DEBUG query-execution-9 com.facebook.presto.execution.QueryStateMachine Query 20170817_061707_00025_mpcq7 is FAILED
    2017-08-17T14:17:07.675+0800 ERROR query-execution-7 com.facebook.presto.execution.QueryStateMachine Query 20170817_061707_00025_mpcq7 failed
    com.facebook.presto.spi.PrestoException: DECIMAL precision must be in range [1, 38]
    at com.facebook.presto.spi.type.DecimalType.validatePrecisionScale(DecimalType.java:94)
    at com.facebook.presto.spi.type.ShortDecimalType.<init>(ShortDecimalType.java:34)
    at com.facebook.presto.spi.type.DecimalType.createDecimalType(DecimalType.java:37)
    at org.apache.carbondata.presto.CarbondataRecordSetProvider.Spi2CarbondataTypeMapper(CarbondataRecordSetProvider.java:259)
    at org.apache.carbondata.presto.CarbondataRecordSetProvider.fillFilter2QueryModel(CarbondataRecordSetProvider.java:134)
    at org.apache.carbondata.presto.CarbondataRecordSetProvider.getRecordSet(CarbondataRecordSetProvider.java:110)
    at org.apache.carbondata.presto.CarbondataPageSourceProvider.createPageSource(CarbondataPageSourceProvider.java:48)
    at com.facebook.presto.spi.connector.classloader.ClassLoaderSafeConnectorPageSourceProvider.createPageSource(ClassLoaderSafeConnectorPageSourceProvider.java:44)
    at com.facebook.presto.split.PageSourceManager.createPageSource(PageSourceManager.java:56)
    at com.facebook.presto.operator.ScanFilterAndProjectOperator.getOutput(ScanFilterAndProjectOperator.java:213)
    at com.facebook.presto.operator.Driver.processInternal(Driver.java:378)
    at com.facebook.presto.operator.Driver.processFor(Driver.java:301)
    at com.facebook.presto.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:622)
    at com.facebook.presto.execution.TaskExecutor$PrioritizedSplitRunner.process(TaskExecutor.java:534)
    at com.facebook.presto.execution.TaskExecutor$Runner.run(TaskExecutor.java:670)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
   
   
    The pr-1234 branch:
   
    git fetch origin pull/1234/head:pr-1234
   
    sql: select * from nation where n_name='ALGERIA';
   
    select * from nation where n_name='ALGERIA';
     n_nationkey | n_name  | n_regionkey |                      n_comment                      
    -------------+---------+-------------+-----------------------------------------------------
               0 | ALGERIA |           0 |  haggle. carefully final deposits detect slyly agai


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user linqer commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    [CARBONDATA-issue number>] Title of the pull request
    there is not a existing CARBONDATA-issue number of this bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1234
 
    @linqer please create a jira


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---