[GitHub] carbondata pull request #1236: fixed bug for fetching the error value of dec...

classic Classic list List threaded Threaded
32 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

qiuchenjian-2
Github user steven-qin commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    @anubhav100
    The lastest master branch:
    create statement: carbon.sql("create table partsupp2 ( ps_partkey int ,ps_suppkey int ,ps_availqty int , ps_supplycost decimal(15,2) ,ps_comment string ) stored by 'carbondata'")
    load statement: carbon.sql("LOAD DATA INPATH '/testdata/partsupp2.csv' INTO TABLE partsupp2  OPTIONS('DELIMITER'='\u0001')")
   
    sql: select * from partsupp2;
   
     ps_partkey | ps_suppkey | ps_availqty | ps_supplycost |                                                                                            ps_comment                              
    ------------+------------+-------------+---------------+-------------------------------------------------------------------------------------------------------------------------------------
              1 |          2 |        3325 | 7.72          | , even theodolites. regular, final theodolites eat after the carefully pending foxes. furiously regular deposits sleep slyly. carefu
          75001 |          2 |        8893 | 1.80          | . blithely regular platelets sleep fluffily ironic, regular platelets. slyly regular deposits nag. packages are furiously according
   
   
    in spark-shell:
   
    sql: carbon.sql("select * from partsupp2").show
    +----------+----------+-----------+-------------+--------------------+
    |ps_partkey|ps_suppkey|ps_availqty|ps_supplycost|          ps_comment|
    +----------+----------+-----------+-------------+--------------------+
    |         1|         2|       3325|       771.64|, even theodolite...|
    |     75001|         2|       8893|       179.82|. blithely regula...|
    +----------+----------+-----------+-------------+--------------------+
   
   
    The pr-1236 branch:
   
    git fetch origin pull/1236/head:pr-1236
   
    sql: select * from partsupp2;
   
    ps_partkey | ps_suppkey | ps_availqty | ps_supplycost |                                                                                            ps_comment                              
    ------------+------------+-------------+---------------+-------------------------------------------------------------------------------------------------------------------------------------
              1 |          2 |        3325 | 771.64        | , even theodolites. regular, final theodolites eat after the carefully pending foxes. furiously regular deposits sleep slyly. carefu
          75001 |          2 |        8893 | 179.82        | . blithely regular platelets sleep fluffily ironic, regular platelets. slyly regular deposits nag. packages are furiously according
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user steven-qin commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    @anubhav100
    There is not carbondata issue No.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user bhavya411 commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    Hi @steven-qin  can you please remove the extra import " import com.google.common.base.Strings;" from CarbondataRecordCursor. I have verified the PR for both LongDecimalType and ShortDecimalType and it is working fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user steven-qin commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    @bhavya411
    I has removed the extra import " import com.google.common.base.Strings;". Please check it again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user bhavya411 commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    verified


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/212/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: fixed bug for fetching the error value of decimal ty...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/214/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: [CARBONDATA-1392]Fixed bug for fetching the error va...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    SDV Build Success with Spark 2.1, Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/246/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: [CARBONDATA-1392]Fixed bug for fetching the error va...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: [CARBONDATA-1392]Fixed bug for fetching the error va...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user bhavya411 commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1236: [CARBONDATA-1392]Fixed bug for fetching the error va...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1236
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1236: [CARBONDATA-1392]Fixed bug for fetching the e...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1236


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12