Apache CarbonData Dev Mailing List archive › Apache CarbonData JIRA issues

[GitHub] carbondata pull request #1308: [CARBONDATA-1440]Fix coverity issues

Classic

List

Threaded

37 messages Options

qiuchenjian-2

[GitHub] carbondata pull request #1308: [CARBONDATA-1440]Fix coverity issues

GitHub user sraghunandan opened a pull request:

https://github.com/apache/carbondata/pull/1308

[CARBONDATA-1440]Fix coverity issues

https://scan.coverity.com/dashboard

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sraghunandan/carbondata-1 coverity_fortify_fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/1308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1308

----
commit 1e7871098e8802b27d108bd96e10e92fd27f261b
Author: sraghunandan <[hidden email]>
Date: 2017-08-27T18:07:05Z

coverity & fortify fixes

----

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

qiuchenjian-2

[GitHub] carbondata issue #1308: [CARBONDATA-1440]Fix coverity issues

Github user sraghunandan commented on the issue:

https://github.com/apache/carbondata/pull/1308

retest this please

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

qiuchenjian-2

[GitHub] carbondata issue #1308: [CARBONDATA-1440]Fix coverity issues

In reply to this post by qiuchenjian-2

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1308

SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/540/

---

qiuchenjian-2

[GitHub] carbondata pull request #1308: [CARBONDATA-1440]Fix coverity issues

In reply to this post by qiuchenjian-2

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1308#discussion_r137256155

--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeFixLengthColumnPage.java ---
@@ -223,39 +223,39 @@ public BigDecimal getDecimal(int rowId) {
@Override
public int[] getIntPage() {
int[] data = new int[getPageSize()];
- for (int i = 0; i < data.length; i++) {
+ for (long i = 0; i < data.length; i++) {
long offset = i << intBits;
- data[i] = CarbonUnsafe.getUnsafe().getInt(baseAddress, baseOffset + offset);
+ data[(int)i] = CarbonUnsafe.getUnsafe().getInt(baseAddress, baseOffset + offset);
}
return data;
}

@Override
public long[] getLongPage() {
long[] data = new long[getPageSize()];
- for (int i = 0; i < data.length; i++) {
+ for (long i = 0; i < data.length; i++) {
long offset = i << longBits;
- data[i] = CarbonUnsafe.getUnsafe().getLong(baseAddress, baseOffset + offset);
+ data[(int)i] = CarbonUnsafe.getUnsafe().getLong(baseAddress, baseOffset + offset);
}
return data;
}

@Override
public float[] getFloatPage() {
float[] data = new float[getPageSize()];
- for (int i = 0; i < data.length; i++) {
+ for (long i = 0; i < data.length; i++) {
--- End diff --

why this modification is needed?

---

qiuchenjian-2