[GitHub] carbondata pull request #1311: [Carbondata 1439] Wrong Error message shown f...

[qiuchenjian-2]

GitHub user shivangi1015 opened a pull request:

    https://github.com/apache/carbondata/pull/1311

    [Carbondata 1439] Wrong Error message shown for Bad records even when BAD_RECORDS_LOGGER_ENABLE is set to true

    This PR corrects the error message for bad records scenario when BAD_RECORDS_LOGGER_ENABLE is set to true.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shivangi1015/incubator-carbondata CARBONDATA-1439

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1311.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1311
   
----
commit 7b4f0a11c12323b725ccb1a1b2997fc017e3b6bb
Author: shivangi <[hidden email]>
Date:   2017-08-04T07:55:02Z

    Corrected error message for bad records scenario when BAD_RECORS_ENABLE is set to true

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Do not change the format.keep @override in previous line


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user shivangi1015 commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    I have corrected this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1311#discussion_r137280154
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java ---
    @@ -158,8 +158,10 @@ public CarbonRow convert(CarbonRow row) throws CarbonDataLoadingException {
           if (!logHolder.isLogged() && logHolder.isBadRecordNotAdded()) {
             badRecordLogger.addBadRecordsToBuilder(copy.getData(), logHolder.getReason());
             if (badRecordLogger.isDataLoadFail()) {
    -          String error = "Data load failed due to bad record: " + logHolder.getReason() +
    --- End diff --
   
    What is wrong with this message?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    @shivangi1015 ...kindly rebase this PR..it has merge conflicts


---

[qiuchenjian-2]

Github user shivangi1015 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1311#discussion_r157137865
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/RowConverterImpl.java ---
    @@ -158,8 +158,10 @@ public CarbonRow convert(CarbonRow row) throws CarbonDataLoadingException {
           if (!logHolder.isLogged() && logHolder.isBadRecordNotAdded()) {
             badRecordLogger.addBadRecordsToBuilder(copy.getData(), logHolder.getReason());
             if (badRecordLogger.isDataLoadFail()) {
    -          String error = "Data load failed due to bad record: " + logHolder.getReason() +
    --- End diff --
   
    Even when the BAD_RECORDS_ENABLE is set to true, the error message includes this: enable the bad record logger to know the detail reason.


---

[qiuchenjian-2]

Github user sraghunandan commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    retest this please



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    add to whitelist


---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    add to whitelist


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2451/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2187/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1311
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/985/



---