[GitHub] carbondata pull request #1321: [CARBONDATA-1438] Unify the sort column and s...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/58/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/181/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/182/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/59/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/811/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/184/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/812/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/61/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/185/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/813/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/815/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/816/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/187/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/63/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/818/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1321#discussion_r139300959
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -433,10 +442,23 @@ case class LoadTable(
           val dateFormat = options.getOrElse("dateformat", null)
           ValidateUtil.validateDateFormat(dateFormat, table, tableName)
           val maxColumns = options.getOrElse("maxcolumns", null)
    -      val sortScope = options.getOrElse("sort_scope", null)
    +
    +      val tableProperties = table.getTableInfo.getFactTable.getTableProperties
    +      val sortScope = if (null == tableProperties) {
    +        CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT
    +      } else {
    +        tableProperties.getOrDefault("sort_scope",
    +          CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT)
    +      }
    +
    --- End diff --
   
    Don't hardcode the sort scope here, you should get from carbon properties. Please use the code like below.
    ```
    val sortScopeDefault = CarbonProperties.getInstance().
            getProperty(CarbonLoadOptionConstants.CARBON_OPTIONS_SORT_SCOPE,
            CarbonProperties.getInstance().getProperty(CarbonCommonConstants.LOAD_SORT_SCOPE,
              CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT))
          val sortScope = if (null == tableProperties) {
            sortScopeDefault
          } else {
            tableProperties.getOrDefault("sort_scope", sortScopeDefault)
          }
    ```


---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1321#discussion_r139301875
 
    --- Diff: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala ---
    @@ -433,10 +442,23 @@ case class LoadTable(
           val dateFormat = options.getOrElse("dateformat", null)
           ValidateUtil.validateDateFormat(dateFormat, table, tableName)
           val maxColumns = options.getOrElse("maxcolumns", null)
    -      val sortScope = options.getOrElse("sort_scope", null)
    +
    +      val tableProperties = table.getTableInfo.getFactTable.getTableProperties
    +      val sortScope = if (null == tableProperties) {
    +        CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT
    +      } else {
    +        tableProperties.getOrDefault("sort_scope",
    +          CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT)
    +      }
    +
    --- End diff --
   
    ok, already update.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/71/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/194/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1321
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/72/



---