[GitHub] carbondata pull request #1322: [CARBONDATA-1450] Support timestamp more than...

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/790/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/167/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/42/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/796/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/178/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/55/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/809/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/86/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/210/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/841/



---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1322#discussion_r139386365
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java ---
    @@ -211,10 +213,21 @@ private static Object getDirectDictionaryDefaultValue(DataType dataType, byte[]
        * @param defaultValue
        * @return
        */
    -  private static Object getNoDictionaryDefaultValue(byte[] defaultValue) {
    +  private static Object getNoDictionaryDefaultValue(DataType datatype, byte[] defaultValue) {
         Object noDictionaryDefaultValue = null;
         if (!isDefaultValueNull(defaultValue)) {
    -      noDictionaryDefaultValue = UTF8String.fromBytes(defaultValue);
    +      switch (datatype) {
    +        case INT:
    +          noDictionaryDefaultValue = ByteUtil.toInt(defaultValue, 0, defaultValue.length);
    +          break;
    +        case LONG:
    +        case TIMESTAMP:
    +          long timestampValue = ByteUtil.toLong(defaultValue, 0, defaultValue.length);
    --- End diff --
   
    Here Long case to be separately handled.


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1322#discussion_r139389587
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala ---
    @@ -31,6 +31,42 @@ class TestSortColumns extends QueryTest with BeforeAndAfterAll {
         sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE origintable1 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
       }
     
    +  test("create table sort columns dictionary include - int") {
    --- End diff --
   
    Add test cases for Int and Long no-Dictionary cases


---

[qiuchenjian-2]

Github user dhatchayani commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1322#discussion_r139395822
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala ---
    @@ -31,6 +31,42 @@ class TestSortColumns extends QueryTest with BeforeAndAfterAll {
         sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE origintable1 OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '\"')""")
       }
     
    +  test("create table sort columns dictionary include - int") {
    --- End diff --
   
    added


---

[qiuchenjian-2]

Github user dhatchayani commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1322#discussion_r139395991
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java ---
    @@ -211,10 +213,21 @@ private static Object getDirectDictionaryDefaultValue(DataType dataType, byte[]
        * @param defaultValue
        * @return
        */
    -  private static Object getNoDictionaryDefaultValue(byte[] defaultValue) {
    +  private static Object getNoDictionaryDefaultValue(DataType datatype, byte[] defaultValue) {
         Object noDictionaryDefaultValue = null;
         if (!isDefaultValueNull(defaultValue)) {
    -      noDictionaryDefaultValue = UTF8String.fromBytes(defaultValue);
    +      switch (datatype) {
    +        case INT:
    +          noDictionaryDefaultValue = ByteUtil.toInt(defaultValue, 0, defaultValue.length);
    +          break;
    +        case LONG:
    +        case TIMESTAMP:
    +          long timestampValue = ByteUtil.toLong(defaultValue, 0, defaultValue.length);
    --- End diff --
   
    handled


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/846/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/91/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/847/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1322
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/216/



---