[GitHub] carbondata pull request #1335: [CARBONDATA-1452] Issue with loading timestam...

[qiuchenjian-2]

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1335

    [CARBONDATA-1452] Issue with loading timestamp data within cutoff when timestamp column is dictionary_include

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata cutoff_timestamp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1335
   
----
commit 07c70e4907457b618a3d5870befb559f3d82ceaa
Author: dhatchayani <[hidden email]>
Date:   2017-09-06T10:13:56Z

    [CARBONDATA-1452] Issue with loading timestamp data within cutoff when timestamp column is dictionary_include

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/564/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    @dhatchayani hi, can you provide detail error message? I cannot understand why we should modify this.


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1335#discussion_r138007579
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java ---
    @@ -188,11 +188,7 @@ private int getDirectSurrogateForMember(String memberStr) {
           return null;
         }
         long timeStamp = 0;
    -    if (cutOffTimeStamp >= 0) {
    -      timeStamp = ((key - 2) * granularityFactor + cutOffTimeStamp);
    -    } else {
    -      timeStamp = (key - 2) * granularityFactor;
    -    }
    +    timeStamp = ((key - 2) * granularityFactor + cutOffTimeStamp);
    --- End diff --
   
    Keep line 190 and 191 in single line


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    @dhatchayani Can you provide more details of this PR.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/709/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/723/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1335
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1335


---