[GitHub] carbondata pull request #1341: [CARBONDATA-1463] CompareTest should validate...

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1341: [CARBONDATA-1463] CompareTest should validate...

qiuchenjian-2
GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1341

    [CARBONDATA-1463] CompareTest should validate result size

    CompareTest for spark2.1 should only validate result size instead of result value, because some test case include aggregation on double column which will give different result since carbon records are sorted

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1341
   
----
commit 2463fb29b692bb80a329d948cf3599d6baa6bd3a
Author: Jacky Li <[hidden email]>
Date:   2017-09-08T14:06:41Z

    change validation

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1341: [CARBONDATA-1463] CompareTest should validate result...

qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1341
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/617/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1341: [CARBONDATA-1463] CompareTest should validate result...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1341
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1341: [CARBONDATA-1463] CompareTest should validate...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1341


---