[GitHub] carbondata pull request #1347: [CARBONDATA-1465] resolved bug for hive cant ...

[qiuchenjian-2]

GitHub user anubhav100 opened a pull request:

    https://github.com/apache/carbondata/pull/1347

    [CARBONDATA-1465] resolved bug for hive cant query carbon table when column name is in …

    1.resolved bug for hive can't query carbon when column name is in small letters
    2.corrected the hive guide there is no need  of alter table statement to alter location now it is done by carbonhivemetastore event listener itself

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata bugfix/CARBONDATA-1465

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1347
   
----
commit 860480e6225a36f23eb9d85aa63df24b11e36623
Author: anubhav100 <[hidden email]>
Date:   2017-09-11T10:28:16Z

    resolved bug for hive cant query carbon table when column name is in captial letter

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1347
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/666/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1347
 
    @chenliang613 @cenyuhai


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1347
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3/



---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1347#discussion_r138603161
 
    --- Diff: integration/hive/hive-guide.md ---
    @@ -91,7 +91,6 @@ $HIVE_HOME/bin/hive
     ### Query data from hive table
     
     ```
    -alter table hive_carbon set location '<hdfs store path>/hive_carbon';
    --- End diff --
   
    why remove this row description?


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1347#discussion_r138604013
 
    --- Diff: integration/hive/hive-guide.md ---
    @@ -91,7 +91,6 @@ $HIVE_HOME/bin/hive
     ### Query data from hive table
     
     ```
    -alter table hive_carbon set location '<hdfs store path>/hive_carbon';
    --- End diff --
   
    @chenliang613 there is no need of alter table statement to alter location now it is done by CarbonHiveMetastore Event listener itself


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1347#discussion_r138604260
 
    --- Diff: integration/hive/hive-guide.md ---
    @@ -91,7 +91,6 @@ $HIVE_HOME/bin/hive
     ### Query data from hive table
     
     ```
    -alter table hive_carbon set location '<hdfs store path>/hive_carbon';
    --- End diff --
   
    @chenliang613 this code right here
     val serdeInfo = table.getSd.getSerdeInfo
                serdeInfo.setSerializationLib("org.apache.carbondata.hive.CarbonHiveSerDe")
                val tablePath = serdeInfo.getParameters.get("tablePath")
                if (tablePath != null) {
                  table.getSd.setLocation(tablePath)
                }


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1347
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1347


---