[GitHub] carbondata pull request #1350: [CARBONDATA-1475] fix default maven dependenc...

[qiuchenjian-2]

GitHub user QiangCai opened a pull request:

    https://github.com/apache/carbondata/pull/1350

    [CARBONDATA-1475] fix default maven dependencies for Intellij Idea

    When we choose spark-1.6, Intellij Idea dependency scala-2.11.
    This PR will fix this issue.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/QiangCai/carbondata default_dependencies

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1350
   
----
commit 29978231931c5af6c6eb7adf1df9e2594dad3c7b
Author: QiangCai <[hidden email]>
Date:   2017-09-12T14:36:13Z

    fixed maven dependencies for intellij idea

----


---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1350#discussion_r138381266
 
    --- Diff: examples/spark2/pom.xml ---
    @@ -38,32 +38,6 @@
           <groupId>org.apache.carbondata</groupId>
           <artifactId>carbondata-spark2</artifactId>
           <version>${project.version}</version>
    -      <exclusions>
    -        <exclusion>
    -          <groupId>org.apache.spark</groupId>
    --- End diff --
   
    why need remove these exclusions ?  in spark2 module, need to exclude 2.10 dependency jars


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/710/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    please retest this


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2/



---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1350#discussion_r138508711
 
    --- Diff: examples/spark2/pom.xml ---
    @@ -38,32 +38,6 @@
           <groupId>org.apache.carbondata</groupId>
           <artifactId>carbondata-spark2</artifactId>
           <version>${project.version}</version>
    -      <exclusions>
    -        <exclusion>
    -          <groupId>org.apache.spark</groupId>
    --- End diff --
   
    now spark-2.1 is the default profile. no need to exclusions spark-2.1 dependencies in spark2 module.


---

[qiuchenjian-2]

Github user QiangCai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1350#discussion_r138508754
 
    --- Diff: examples/spark2/pom.xml ---
    @@ -38,32 +38,6 @@
           <groupId>org.apache.carbondata</groupId>
           <artifactId>carbondata-spark2</artifactId>
           <version>${project.version}</version>
    -      <exclusions>
    -        <exclusion>
    -          <groupId>org.apache.spark</groupId>
    --- End diff --
   
    I moved these exclusions to spark module.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/718/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/719/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/830/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/726/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    mvn clean test -Pspark-2.1
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
    [INFO] Apache CarbonData :: Parent ........................ SUCCESS [  1.689 s]
    [INFO] Apache CarbonData :: Common ........................ SUCCESS [  7.008 s]
    [INFO] Apache CarbonData :: Core .......................... SUCCESS [01:12 min]
    [INFO] Apache CarbonData :: Processing .................... SUCCESS [ 21.645 s]
    [INFO] Apache CarbonData :: Hadoop ........................ SUCCESS [ 19.416 s]
    [INFO] Apache CarbonData :: Spark Common .................. SUCCESS [ 47.740 s]
    [INFO] Apache CarbonData :: Spark2 ........................ SUCCESS [03:49 min]
    [INFO] Apache CarbonData :: Spark Common Test ............. SUCCESS [11:23 min]
    [INFO] Apache CarbonData :: Assembly ...................... SUCCESS [  3.083 s]
    [INFO] Apache CarbonData :: Hive .......................... SUCCESS [ 20.557 s]
    [INFO] Apache CarbonData :: presto ........................ SUCCESS [ 16.347 s]
    [INFO] Apache CarbonData :: Spark2 Examples ............... SUCCESS [ 15.328 s]
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 18:58 min
    [INFO] Finished at: 2017-09-13T20:00:05+08:00
    [INFO] Final Memory: 135M/842M
    [INFO] ------------------------------------------------------------------------
   
     mvn clean test -Pspark-1.6
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
    [INFO] Apache CarbonData :: Parent ........................ SUCCESS [  2.756 s]
    [INFO] Apache CarbonData :: Common ........................ SUCCESS [  7.896 s]
    [INFO] Apache CarbonData :: Core .......................... SUCCESS [01:17 min]
    [INFO] Apache CarbonData :: Processing .................... SUCCESS [ 22.714 s]
    [INFO] Apache CarbonData :: Hadoop ........................ SUCCESS [ 19.481 s]
    [INFO] Apache CarbonData :: Spark Common .................. SUCCESS [ 49.917 s]
    [INFO] Apache CarbonData :: Spark ......................... SUCCESS [02:11 min]
    [INFO] Apache CarbonData :: Spark Common Test ............. SUCCESS [10:46 min]
    [INFO] Apache CarbonData :: Assembly ...................... SUCCESS [  0.478 s]
    [INFO] Apache CarbonData :: Spark Examples ................ SUCCESS [ 17.637 s]
    [INFO] Apache CarbonData :: Flink Examples ................ SUCCESS [  1.704 s]
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 16:18 min
    [INFO] Finished at: 2017-09-13T20:38:30+08:00
    [INFO] Final Memory: 97M/769M
    [INFO] ------------------------------------------------------------------------



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    please retest this


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/144/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/268/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/900/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1198/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/567/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1350
 
    close this pr. not required


---