[GitHub] carbondata pull request #1354: [CARBONDATA-1348] Sort_Column should not supp...

[qiuchenjian-2]

GitHub user rahulforallp opened a pull request:

    https://github.com/apache/carbondata/pull/1354

    [CARBONDATA-1348] Sort_Column should not supported for no-dictionary …

    Sort_Column should not supported for no dictionary column having numeric data-type and measure column.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulforallp/incubator-carbondata CARBONDATA-1348

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1354
   
----
commit 610021a167cda6f87369d27f24b92741d43163bb
Author: rahulforallp <[hidden email]>
Date:   2017-09-13T10:13:33Z

    [CARBONDATA-1348] Sort_Column should not supported for no-dictionary column with numeric data-type and measure column

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/100/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/101/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/102/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Why is this required? Is there any bug?


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/7/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/733/



---

[qiuchenjian-2]

Github user xuchuanyin commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    I used numeric-no-dictionary column in SORT_COLUMN and did not find any problems for now.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    @jackylk @xuchuanyin  Currently sorting is happening on bytes only. So if the sort columns on numerics and those numerics are negative then sort gives the problem.
    So we can disable it currently and after fixing this issue we can enable back.


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/753/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/757/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/137/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/11/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    @rahulforallp Please fix the test failures


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/769/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/17/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/143/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/773/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1354
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/777/



---