[GitHub] carbondata pull request #1356: [CARBONDATA-1477] corrected the bug for wrong...

[qiuchenjian-2]

GitHub user anubhav100 opened a pull request:

    https://github.com/apache/carbondata/pull/1356

    [CARBONDATA-1477] corrected the bug for wrong values of date data type

    https://issues.apache.org/jira/browse/CARBONDATA-1477

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-1477

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1356.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1356
   
----
commit d9d7eb8fbda99e4627589df19684ebd8a8c8ee89
Author: anubhav100 <[hidden email]>
Date:   2017-09-13T12:20:19Z

    corrected the bug for wrong values of date data type

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/106/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    @chenliang613 @cenyuhai


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/9/



---

[qiuchenjian-2]

Github user cenyuhai commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1356#discussion_r138654019
 
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java ---
    @@ -228,9 +229,13 @@ private Writable createWritablePrimitive(Object obj, CarbonColumn carbonColumn)
           case LONG:
             return new LongWritable((long) obj);
           case SHORT:
    -        return new ShortWritable((Short) obj);
    +        return new ShortWritable((short) obj);
           case DATE:
    -        return new DateWritable(new Date(((Integer) obj).longValue()));
    +        Calendar c = Calendar.getInstance();
    +        c.setTime(new Date(0));
    --- End diff --
   
    Does it mean current time? and then reset the year to current year?


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1356#discussion_r138656706
 
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java ---
    @@ -228,9 +229,13 @@ private Writable createWritablePrimitive(Object obj, CarbonColumn carbonColumn)
           case LONG:
             return new LongWritable((long) obj);
           case SHORT:
    -        return new ShortWritable((Short) obj);
    +        return new ShortWritable((short) obj);
           case DATE:
    -        return new DateWritable(new Date(((Integer) obj).longValue()));
    +        Calendar c = Calendar.getInstance();
    +        c.setTime(new Date(0));
    --- End diff --
   
    Yup


---

[qiuchenjian-2]

Github user anubhav100 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1356#discussion_r138659199
 
    --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/CarbonDictionaryDecodeReadSupport.java ---
    @@ -228,9 +229,13 @@ private Writable createWritablePrimitive(Object obj, CarbonColumn carbonColumn)
           case LONG:
             return new LongWritable((long) obj);
           case SHORT:
    -        return new ShortWritable((Short) obj);
    +        return new ShortWritable((short) obj);
           case DATE:
    -        return new DateWritable(new Date(((Integer) obj).longValue()));
    +        Calendar c = Calendar.getInstance();
    +        c.setTime(new Date(0));
    --- End diff --
   
    There are changes in master code for date so these changes are required for getting the right values at hive side


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/735/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    @chenliang613 can you review this pr?


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/159/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/788/



---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    Retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/53/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/179/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/807/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    @anubhav100 can you provide data.csv file which you tested, let me verify it.


---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    @chenliang613 I attached the csv with same JIRA issue https://issues.apache.org/jira/browse/CARBONDATA-1477
   
   
   
   



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1356
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1356


---