[GitHub] carbondata pull request #1370: [CARBONDATA-1488] JVM crashes when unsafe col...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/1370

    [CARBONDATA-1488] JVM crashes when unsafe columnpage is enabled

    The test case `BadRecordEmptyDataTest.test load multiple loads- pne with valid record and one with invalid` crashes when unsafe columnpage is enabled
    It is because of capacity size calculation in unsafe var page.
    Fixed capacity size calculation when column value size is larger than initial capacity in this PR.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata presto-build-all

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1370
   
----
commit 058ad83940dcc77f3f279188eadd79f1d01b27df
Author: Ravindra Pesala <[hidden email]>
Date:   2017-09-19T10:54:35Z

    Fixed capacity size calculation when column value size is larger than initial capacity

----


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1370#discussion_r139664120
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorizedRecordReader.java ---
    @@ -72,7 +72,7 @@
       /**
        * The default config on whether columnarBatch should be offheap.
    --- End diff --
   
    please change comment also


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1370#discussion_r139664458
 
    --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorizedRecordReader.java ---
    @@ -72,7 +72,7 @@
       /**
        * The default config on whether columnarBatch should be offheap.
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1370
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/234/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1370
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/110/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1370
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/864/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1370
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1370


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1370
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/865/



---