[GitHub] carbondata pull request #1381: [CARBONDATA-1449]Fixed date and timestamp fil...

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1381: [CARBONDATA-1449]Fixed date and timestamp fil...

qiuchenjian-2
GitHub user kumarvishal09 opened a pull request:

    https://github.com/apache/carbondata/pull/1381

    [CARBONDATA-1449]Fixed date and timestamp filter gc issue in case of direct dictionary

    **Problem:** When date or timestamp filter is going to row level there is lots of gc this is because for each row it is creating new direct dictionary object for data type;
    **Solution:** create one object and use the same.
    Improvement tested with 2million rows:
    ~19 seconds to ~9 seconds

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kumarvishal09/incubator-carbondata DateAndTimeStampFilterGCIssueInCaseOfDirectDictionary

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1381
   
----
commit f6baa02ee6d7af550fa0592a0f1e03b201a41d68
Author: kumarvishal <[hidden email]>
Date:   2017-09-25T11:36:21Z

    Fixed date filter gc issue in case of direct dictionary

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/286/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/161/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/917/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/162/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/288/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/918/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    retest this please


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/167/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/292/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/923/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1381: [CARBONDATA-1449]Fixed date and timestamp filter gc ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1381
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1381: [CARBONDATA-1449]Fixed date and timestamp fil...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1381


---