[GitHub] carbondata pull request #1386: [CARBONDATA-1513] [WIP] bad-record for comple...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/425/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/300/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1054/



---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1386#discussion_r143977291
 
    --- Diff: integration/spark-common-test/src/test/resources/complexdatawithheader.csv ---
    @@ -0,0 +1,101 @@
    +  deviceInformationId,channelsId,ROMSize,purchasedate,mobile,MAC,locationinfo,proddate,gamePointId,contractNumber
    --- End diff --
   
    @jackylk yes we can reduce no of rows. Done.


---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    @rahulforallp Can you rebase it please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/525/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1155/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1158/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/528/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1188/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/557/



---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/723/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1359/



---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    @jackylk  please review and merge


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1386#discussion_r148524506
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java ---
    @@ -131,6 +131,10 @@ public void getAllPrimitiveChildren(List<GenericDataType> primitiveChild) {
         }
       }
     
    +  public GenericDataType getChildren() {
    --- End diff --
   
    It is better to add it in `GenericDataType` and override it here


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/806/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1439/



---

[qiuchenjian-2]

Github user rahulforallp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1386#discussion_r148955640
 
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java ---
    @@ -131,6 +131,10 @@ public void getAllPrimitiveChildren(List<GenericDataType> primitiveChild) {
         }
       }
     
    +  public GenericDataType getChildren() {
    --- End diff --
   
    @jackylk getChildren() added to GenericDataType and overriden.


---

[qiuchenjian-2]

Github user rahulforallp commented on the issue:

    https://github.com/apache/carbondata/pull/1386
 
    @jackylk review comment resolved . please review and merge.


---