[GitHub] carbondata pull request #1398: [WIP] Fixed version compatabilty issues from ...

classic Classic list List threaded Threaded
67 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1398: [CARBONDATA-1537] Fixed version compatabilty ...

qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1398#discussion_r143816210
 
    --- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/CarbonV1toV3CompatabilityTestCase.scala ---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.cluster.sdv.generated
    +
    +import org.apache.spark.sql.common.util.QueryTest
    +import org.apache.spark.sql.hive.CarbonSessionState
    +import org.apache.spark.sql.test.TestQueryExecutor
    +import org.apache.spark.sql.{CarbonEnv, CarbonSession, Row, SparkSession}
    +import org.scalatest.BeforeAndAfterAll
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants
    +import org.apache.carbondata.core.util.CarbonProperties
    +
    +/**
    + * V1 to V3 compatability test. This test has to be at last
    --- End diff --
   
    yes, i will tests for V2 to V3 in another PR, Because I need to verify the compatibility of V2 to V3 first


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1398: [CARBONDATA-1537] Fixed version compatabilty ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1398#discussion_r143816326
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -43,7 +43,7 @@ class CarbonSession(@transient val sc: SparkContext,
       }
     
       @transient
    -  override private[sql] lazy val sessionState: SessionState = new CarbonSessionState(this)
    +  override lazy val sessionState: SessionState = new CarbonSessionState(this)
    --- End diff --
   
    Yes, it is required for test case I added.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1398: [CARBONDATA-1537] Fixed version compatabilty issues ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1398
 
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/294/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1398: [CARBONDATA-1537] Fixed version compatabilty issues ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1398
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/418/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1398: [CARBONDATA-1537] Fixed version compatabilty issues ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1398
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1048/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1398: [CARBONDATA-1537] Fixed version compatabilty issues ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1398
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1398: [CARBONDATA-1537] Fixed version compatabilty ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1398


---
1234