[GitHub] carbondata pull request #1407: [CARBONDATA-1549] CarbonProperties should be ...

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1407
 
    @jackylk  Please review it.


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1407
 
    @xubo245   what are the test errors if not set back default value?
    --------------------------------------------------
    if carbon properties is not default value, it may be affected other test and lead to test error.
   
    Such a big pull request, need raise a discussion in mailing list for your proposal before submitting PR.
   
   



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1407
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1181/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1407
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/550/



---

[qiuchenjian-2]

Github user xubo245 closed the pull request at:

    https://github.com/apache/carbondata/pull/1407


---