GitHub user anubhav100 opened a pull request:
https://github.com/apache/carbondata/pull/1413 [CARBONDATA-1548] resolved bug for creating table with spaces using datasource https://issues.apache.org/jira/browse/CARBONDATA-1548 You can merge this pull request into a Git repository by running: $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-1548 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1413.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1413 ---- commit ebc616881cbfa218b783b63317a2ec289618bc70 Author: anubhav100 <[hidden email]> Date: 2017-10-13T10:19:27Z resolved bug for creating table with spaces using datasource ---- --- |
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/441/ --- |
In reply to this post by qiuchenjian-2
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/1413 retest this please --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/442/ --- |
In reply to this post by qiuchenjian-2
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/1413 retest this please --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1413 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1070/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/319/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/444/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1413 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1071/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1413 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1072/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1413#discussion_r145030920 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala --- @@ -233,10 +233,17 @@ object CarbonSource { * @return */ def updateCatalogTableWithCarbonSchema(tableDesc: CatalogTable, - sparkSession: SparkSession): CatalogTable = { + sparkSession: SparkSession): CatalogTable = { val metaStore = CarbonEnv.getInstance(sparkSession).carbonMetastore val storageFormat = tableDesc.storage val properties = storageFormat.properties + tableDesc.storage.properties.get("tableName") match { --- End diff -- is it `tableName` mandatory here? tableName validation is not happened in parser? --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1413 Please add test case --- |
In reply to this post by qiuchenjian-2
Github user anubhav100 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1413#discussion_r145876968 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSource.scala --- @@ -233,10 +233,17 @@ object CarbonSource { * @return */ def updateCatalogTableWithCarbonSchema(tableDesc: CatalogTable, - sparkSession: SparkSession): CatalogTable = { + sparkSession: SparkSession): CatalogTable = { val metaStore = CarbonEnv.getInstance(sparkSession).carbonMetastore val storageFormat = tableDesc.storage val properties = storageFormat.properties + tableDesc.storage.properties.get("tableName") match { --- End diff -- @ravipesala 1.tableName validation does not take place in parser when you datasource ddl 2.test case is already there in carbondatasource suite i just modified it to check that when exception is thrown table should not be there in store --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1413 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1177/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/546/ --- |
In reply to this post by qiuchenjian-2
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/1413 @ravipesala can you review this PR? --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1414/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/962/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3063/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1413 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4307/ --- |
Free forum by Nabble | Edit this page |