[GitHub] carbondata pull request #1417: [WIP] Add precision and scale to DecimalType

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/499/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1123/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1127/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/522/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1152/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1156/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/526/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1174/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/543/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/671/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1308/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/698/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1333/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/700/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1336/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/703/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1417
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1339/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1417#discussion_r147632046
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeVarLengthColumnPage.java ---
    @@ -42,6 +42,16 @@
         baseOffset = memoryBlock.getBaseOffset();
       }
     
    +  UnsafeVarLengthColumnPage(TableSpec.ColumnSpec columnSpec, DataType dataType, int pageSize,
    --- End diff --
   
    It is not used anywhere, please remove it if not required


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1417#discussion_r147638842
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
    @@ -1862,9 +1863,31 @@ public static TableInfo convertGsonToTableInfo(Map<String, String> properties) {
           builder.append(part);
         }
         TableInfo tableInfo = gson.fromJson(builder.toString(), TableInfo.class);
    +    updateDecimalType(tableInfo);
         return tableInfo;
       }
     
    +  // update decimal type inside `tableInfo` to set scale and precision, if there are any decimal
    +  private static void updateDecimalType(TableInfo tableInfo) {
    +    List<ColumnSchema> deserializedColumns = tableInfo.getFactTable().getListOfColumns();
    +    for (ColumnSchema column : deserializedColumns) {
    +      DataType dataType = column.getDataType();
    +      if (DataTypes.isDecimal(dataType)) {
    +        column.setDataType(DataTypes.createDefaultDecimalType());
    --- End diff --
   
    why we should create default? Already scale and precision must be available inside columnschema.I guess It would be an issue  if we create with default


---