[GitHub] carbondata pull request #1424: [WIP] Remove unused declaration in spark-comm...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1424

    [WIP] Remove unused declaration in spark-common module

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata clean

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1424
   
----
commit 0876f93eec4d67457d170db1beabae12e7281694
Author: Jacky Li <[hidden email]>
Date:   2017-10-20T01:50:18Z

    clean up spark-common module

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/515/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1143/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1171/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/540/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/648/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1288/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    retest this please


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1424#discussion_r147552679
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala ---
    @@ -345,7 +345,6 @@ class CarbonGlobalDictionaryGenerateRDD(
         var status = CarbonCommonConstants.STORE_LOADSTATUS_SUCCESS
         val iter = new Iterator[(Int, String)] {
           var dictionaryForDistinctValueLookUp: Dictionary = _
    -      var dictionaryForSortIndexWriting: Dictionary = _
    --- End diff --
   
    This is not used


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1424#discussion_r147552684
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonIUDMergerRDD.scala ---
    @@ -59,18 +59,8 @@ class CarbonIUDMergerRDD[K, V](
         val jobConf: JobConf = new JobConf(new Configuration)
         val job: Job = new Job(jobConf)
         val format = CarbonInputFormatUtil.createCarbonInputFormat(absoluteTableIdentifier, job)
    -    var defaultParallelism = sparkContext.defaultParallelism
    -    val result = new util.ArrayList[Partition](defaultParallelism)
    -
    -    // mapping of the node and block list.
    -    var nodeMapping: util.Map[String, util.List[Distributable]] = new
    -        util.HashMap[String, util.List[Distributable]]
    -
    -    var noOfBlocks = 0
    -
    -    val taskInfoList = new util.ArrayList[Distributable]
    -
    -    var blocksOfLastSegment: List[TableBlockInfo] = null
    --- End diff --
   
    All these variables are not used


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/715/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1350/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/720/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1357/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/726/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1363/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1424
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/746/



---