[GitHub] carbondata pull request #1429: [WIP] Change Complex type

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1429#discussion_r149011985
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java ---
    @@ -392,9 +392,9 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
           case DATE:
             return DataTypes.DATE;
           case ARRAY:
    -        return DataTypes.ARRAY;
    +        return DataTypes.createDefaultArrayType();
    --- End diff --
   
    Can't we create actual array from the  child schemas here?


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1429#discussion_r149011999
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java ---
    @@ -392,9 +392,9 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
           case DATE:
             return DataTypes.DATE;
           case ARRAY:
    -        return DataTypes.ARRAY;
    +        return DataTypes.createDefaultArrayType();
           case STRUCT:
    -        return DataTypes.STRUCT;
    +        return DataTypes.createDefaultStructType();
    --- End diff --
   
    Can't we create actual array from the  child schemas here?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1429#discussion_r149283956
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java ---
    @@ -392,9 +392,9 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
           case DATE:
             return DataTypes.DATE;
           case ARRAY:
    -        return DataTypes.ARRAY;
    +        return DataTypes.createDefaultArrayType();
    --- End diff --
   
    In schema.thrift, DataType is a Enum, so I think we can not get the child schema from existing table before this PR.


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1429#discussion_r149284049
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java ---
    @@ -392,9 +392,9 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
           case DATE:
             return DataTypes.DATE;
           case ARRAY:
    -        return DataTypes.ARRAY;
    +        return DataTypes.createDefaultArrayType();
           case STRUCT:
    -        return DataTypes.STRUCT;
    +        return DataTypes.createDefaultStructType();
    --- End diff --
   
    In schema.thrift, DataType is a Enum, so I think we can not get the child schema from existing table before this PR.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1429
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/961/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1429
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1577/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1429
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1429


---