[GitHub] carbondata pull request #1434: [CARBONDATA-1593]Add partition to table cause...

[qiuchenjian-2]

GitHub user 397090770 opened a pull request:

    https://github.com/apache/carbondata/pull/1434

    [CARBONDATA-1593]Add partition to table cause NoSuchTableException

    `AlterTableSplitCarbonPartition`'s `processSchema` method doesn't  provide db info to `catalog.refreshTable`, this will cause `NoSuchTableException` when we add partitions to carbondata table.  See [CARBONDATA-1593](https://issues.apache.org/jira/browse/CARBONDATA-1593)
   
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
   
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
       
     - [ ] Make sure to add PR description including
           
            - the root cause/problem statement
            - What is the implemented solution
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
     
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/397090770/carbondata CARBONDATA-1593

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1434
   
----
commit d10d3fea025e37351c6dd8852c6c8e5742c6a71e
Author: wyp <[hidden email]>
Date:   2017-10-25T08:43:47Z

    [CARBONDATA-1593]Add partition to table cause NoSuchTableException

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1434
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1434
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1434
 
    add to whitelist


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1434
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/674/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1434
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1311/



---

[qiuchenjian-2]

Github user lionelcao commented on the issue:

    https://github.com/apache/carbondata/pull/1434
 
    LGTM


---

[qiuchenjian-2]

Github user lionelcao commented on the issue:

    https://github.com/apache/carbondata/pull/1434
 
    @chenliang613 Please help review.


---

[qiuchenjian-2]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1434#discussion_r147375453
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/AlterTableSplitCarbonPartitionCommand.scala ---
    @@ -109,7 +109,7 @@ case class AlterTableSplitCarbonPartitionCommand(
         CarbonUtil.writeThriftTableToSchemaFile(schemaFilePath, thriftTable)
         // update the schema modified time
         carbonMetaStore.updateAndTouchSchemasUpdatedTime(storePath)
    -    sparkSession.catalog.refreshTable(tableName)
    +    sparkSession.catalog.refreshTable(s"$dbName.$tableName")
    --- End diff --
   
    Better to call SessionCatalog.refreshTable rather than Catalog refreshTable as it will honour the DBName.
    sparkSession.sessionState.catalog.refreshTable() and pass TableIdentifier.


---

[qiuchenjian-2]

Github user 397090770 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1434#discussion_r147604867
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/partition/AlterTableSplitCarbonPartitionCommand.scala ---
    @@ -109,7 +109,7 @@ case class AlterTableSplitCarbonPartitionCommand(
         CarbonUtil.writeThriftTableToSchemaFile(schemaFilePath, thriftTable)
         // update the schema modified time
         carbonMetaStore.updateAndTouchSchemasUpdatedTime(storePath)
    -    sparkSession.catalog.refreshTable(tableName)
    +    sparkSession.catalog.refreshTable(s"$dbName.$tableName")
    --- End diff --
   
    @sounakr Thank you for your review.  I will fix this.


---

[qiuchenjian-2]

Github user 397090770 closed the pull request at:

    https://github.com/apache/carbondata/pull/1434


---