[GitHub] carbondata pull request #1437: [CARBONDATA-1618] Fix issue of not support ta...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/752/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1389/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    @chenerlu how the tablecomment added through ddl is persisted? I don't see anywhere the logic to persist the tablecommnet.


---

[qiuchenjian-2]

Github user chenerlu commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/789/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1422/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/790/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1423/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1437#discussion_r148961091
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java ---
    @@ -79,6 +79,9 @@
       // this idenifier is a lazy field which will be created when it is used first time
       private AbsoluteTableIdentifier identifier;
     
    +  // table comment
    +  private String tableComment;
    --- End diff --
   
    no need to add this attribute as it is already stored in properties


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1437
 
    LGTM, comments of this PR will be handled in another PR


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1437


---

[qiuchenjian-2]

Github user pawanmalwal commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1437#discussion_r149586320
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java ---
    @@ -79,6 +79,9 @@
       // this idenifier is a lazy field which will be created when it is used first time
       private AbsoluteTableIdentifier identifier;
     
    +  // table comment
    +  private String tableComment;
    --- End diff --
   
    Handled it in  https://github.com/apache/carbondata/pull/1472


---