[GitHub] carbondata pull request #1438: [WIP]insert overwrite fix

[qiuchenjian-2]

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1438

    [WIP]insert overwrite fix

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
   
     - [ ] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
       
     - [ ] Make sure to add PR description including
           
            - the root cause/problem statement
            - What is the implemented solution
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
     
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
             
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata all_num

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1438.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1438
   
----
commit 42f1b59f2481c2b15d4a920ee99a051393b684d9
Author: akashrn5 <[hidden email]>
Date:   2017-10-26T14:06:46Z

    insert overwrite fix

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/686/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/690/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1323/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    @ravipesala @gvramana @QiangCai @manishgupta88 please review this PR


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1119/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1717/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1438#discussion_r151331644
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala ---
    @@ -186,6 +186,12 @@ case class LoadTableCommand(
               LOGGER.error(ex, s"Dataload failure for $dbName.$tableName")
               throw new RuntimeException(s"Dataload failure for $dbName.$tableName, ${ex.getMessage}")
             case ex: Exception =>
    +          if (ex.isInstanceOf[InterruptedException] &&
    +              ex.getMessage.contains("update fail status")) {
    --- End diff --
   
    It is not good to rely on message inside the exception, can you create one special exception for this case?


---

[qiuchenjian-2]

Github user akashrn5 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1438#discussion_r151332421
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala ---
    @@ -186,6 +186,12 @@ case class LoadTableCommand(
               LOGGER.error(ex, s"Dataload failure for $dbName.$tableName")
               throw new RuntimeException(s"Dataload failure for $dbName.$tableName, ${ex.getMessage}")
             case ex: Exception =>
    +          if (ex.isInstanceOf[InterruptedException] &&
    +              ex.getMessage.contains("update fail status")) {
    --- End diff --
   
    ok, i will add a new Exception for this, and throw that exception


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    @jackylk handled your comment, please review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1167/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1745/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    Please rebase @akashrn5


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1438
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1411/



---

[qiuchenjian-2]

Github user akashrn5 closed the pull request at:

    https://github.com/apache/carbondata/pull/1438


---