[GitHub] carbondata pull request #1444: [CARBONDATA-1653] Rename aggType to measureDa...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1444: [CARBONDATA-1653] Rename aggType to measureDa...

qiuchenjian-2
GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1444

    [CARBONDATA-1653] Rename aggType to measureDataType

    There are many `aggType` in the code, they should be rename to `measureDataType` for better readiability
   
     - [X] Make sure the PR title is formatted like:
       `[CARBONDATA-<Jira issue #>] Description of pull request`
       
     - [X] Make sure to add PR description
   
     - [X ] Any interfaces changed?
       None
   
     - [X] Any backward compatibility impacted?
       None
   
     - [X ] Document update required?
       None
   
     - [X ] Testing done
      Yes
      No new testcase is added
             
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
                     
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata aggtype

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1444.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1444
   
----
commit 0a0781a2d21317bbdf92f20cfdb6606043eeda92
Author: Jacky Li <[hidden email]>
Date:   2017-10-28T10:56:38Z

    rename aggType

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1444: [CARBONDATA-1653] Rename aggType to measureDataType

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1444
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/711/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1444: [CARBONDATA-1653] Rename aggType to measureDataType

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1444
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1347/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1444: [CARBONDATA-1653] Rename aggType to measureDataType

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1444
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1444: [CARBONDATA-1653] Rename aggType to measureDa...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1444


---