[GitHub] carbondata pull request #1460: [Docs] Fix partition-guide.md docs NUM_PARTIT...

[qiuchenjian-2]

GitHub user LiShuMing opened a pull request:

    https://github.com/apache/carbondata/pull/1460

    [Docs] Fix partition-guide.md docs NUM_PARTITIONS wrong keyword

    It's an obvious keyword spelling mistake,  `PARTITION_NUM` should be `NUM_PARTITION `.
   
    No Tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LiShuMing/carbondata fix-docs-partition-guide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1460.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1460
   
----
commit 517a40e0707709ebf4b9812e4208717222ef2e06
Author: lishuming <[hidden email]>
Date:   2017-11-02T03:55:02Z

    Fix partition-guide.md docs NUM_PARTITIONS wrong keyword

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    add to whitelist


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    @LiShuMing  can you explain why?   :)


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/803/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1436/



---

[qiuchenjian-2]

Github user LiShuMing commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    @chenliang613 According https://github.com/apache/carbondata/blob/master/integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala#171 says, `PARTITION_NUM ` keyword should be `NUM_ PARTITION.
   
    I think it's a spelling mistake?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1460#discussion_r150824983
 
    --- Diff: docs/partition-guide.md ---
    @@ -39,7 +39,7 @@ This tutorial is designed to provide a quick introduction to create and use part
        PARTITIONED BY (partition_col_name data_type)
        STORED BY 'carbondata'
        [TBLPROPERTIES ('PARTITION_TYPE'='HASH',
    -                   'PARTITION_NUM'='N' ...)]
    +                   'NUM_PARTITION'='N' ...)]
    --- End diff --
   
    It should be `NUM_PARTITIONS`


---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    @LiShuMing  Likun comment is right, should be : "NUM_PARTITIONS" , please update it .


---

[qiuchenjian-2]

Github user LiShuMing commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    @chenliang613 already done.


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1299/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1768/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1769/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    Can one of the admins verify this patch?


---

[qiuchenjian-2]

Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    please rebase to branch master


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1408/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1853/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    @LiShuMing please rebase


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1460
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/958/



---