[GitHub] carbondata pull request #1467: [CARBONDATA-1669] Clean up code in CarbonData...

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1467#discussion_r149281818
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/AlterTableCompactionCommand.scala ---
    @@ -87,4 +94,113 @@ case class AlterTableCompactionCommand(
         }
         Seq.empty
       }
    +
    +  private def alterTableForCompaction(sqlContext: SQLContext,
    +      alterTableModel: AlterTableModel,
    +      carbonLoadModel: CarbonLoadModel,
    +      storeLocation: String): Unit = {
    +    var compactionSize: Long = 0
    +    var compactionType: CompactionType = CompactionType.MINOR_COMPACTION
    +    if (alterTableModel.compactionType.equalsIgnoreCase("major")) {
    +      compactionSize = CarbonDataMergerUtil.getCompactionSize(CompactionType.MAJOR_COMPACTION)
    +      compactionType = CompactionType.MAJOR_COMPACTION
    +    } else if (alterTableModel.compactionType
    +      .equalsIgnoreCase(CompactionType.IUD_UPDDEL_DELTA_COMPACTION.toString)) {
    +      compactionType = CompactionType.IUD_UPDDEL_DELTA_COMPACTION
    +      if (alterTableModel.segmentUpdateStatusManager.get != None) {
    +        carbonLoadModel
    +          .setSegmentUpdateStatusManager(alterTableModel.segmentUpdateStatusManager.get)
    +
    +        carbonLoadModel
    --- End diff --
   
    fixed


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1467
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/842/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1467
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1475/



---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1467#discussion_r149290867
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/DataManagementFunc.scala ---
    @@ -49,105 +44,6 @@ object DataManagementFunc {
     
       private val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
     
    -  def deleteLoadByDate(
    --- End diff --
   
    Just confirm  :   this method is for spark 1.6?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1467#discussion_r149291386
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/DataManagementFunc.scala ---
    @@ -49,105 +44,6 @@ object DataManagementFunc {
     
       private val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
     
    -  def deleteLoadByDate(
    --- End diff --
   
    No one use this function


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1467
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/846/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1467
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1479/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1467
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1467


---