[GitHub] carbondata pull request #1476: [CARBONDATA-1528][CARBONDATA-1527] [PreAgg] R...

[qiuchenjian-2]

GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1476

    [CARBONDATA-1528][CARBONDATA-1527] [PreAgg] Restrict alter/update/delete for pre-aggregate table

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata add_validation_for_aggregate

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1476
   
----
commit da1af4bd1bd698e7105b6e0a77151e50e7404893
Author: kunal642 <[hidden email]>
Date:   2017-10-23T12:58:15Z

    restrict alter/update/delete for pre-aggregate table

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/913/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1476#discussion_r149908793
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableAddColumnCommand.scala ---
    @@ -59,6 +59,14 @@ private[sql] case class AlterTableAddColumnCommand(
           carbonTable = metastore
             .lookupRelation(Some(dbName), tableName)(sparkSession).asInstanceOf[CarbonRelation]
             .tableMeta.carbonTable
    +      if (carbonTable.isPreAggregateTable) {
    --- End diff --
   
    We can allow alter add column operations


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1476#discussion_r149909385
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableDropColumnCommand.scala ---
    @@ -55,6 +55,14 @@ private[sql] case class AlterTableDropColumnCommand(
           carbonTable = metastore
             .lookupRelation(Some(dbName), tableName)(sparkSession).asInstanceOf[CarbonRelation]
             .tableMeta.carbonTable
    +      if (carbonTable.isPreAggregateTable) {
    --- End diff --
   
    we should check the children tables columns and throw the exception if drop column matches any child table column along with information of tables


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1476#discussion_r149909553
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableRenameTableCommand.scala ---
    @@ -82,6 +82,14 @@ private[sql] case class AlterTableRenameTableCommand(
           val tableMeta = metastore.lookupRelation(Some(oldDatabaseName), oldTableName)(sparkSession)
             .asInstanceOf[CarbonRelation].tableMeta
           carbonTable = tableMeta.carbonTable
    +      if (carbonTable.isPreAggregateTable) {
    --- End diff --
   
    We can rename the parents of all child tables, we can support this operation.


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1476#discussion_r149909681
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/AlterTableDropColumnCommand.scala ---
    @@ -55,6 +55,14 @@ private[sql] case class AlterTableDropColumnCommand(
           carbonTable = metastore
             .lookupRelation(Some(dbName), tableName)(sparkSession).asInstanceOf[CarbonRelation]
             .tableMeta.carbonTable
    +      if (carbonTable.isPreAggregateTable) {
    --- End diff --
   
    Add all these verifications on pre-event listener


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/922/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1528/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/924/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1538/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1539/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/946/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1561/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/979/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/988/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1593/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1596/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1605/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    @ravipesala Please review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1476
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1001/



---