[GitHub] carbondata pull request #1481: [CARBONDATA-1576] Added create datamap parser...

[qiuchenjian-2]

GitHub user ravipesala opened a pull request:

    https://github.com/apache/carbondata/pull/1481

    [CARBONDATA-1576] Added create datamap parser and saved to schema file

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
       User can create datamap using the following syntax.
       ```
        CREATE DATAMAP agg_sales
         ON TABLE sales
       USING "org.apache.carbondata.datamap.AggregateDataMapHandler"
      DMPROPERTIES (
        'KEY’=’VALUE’
       ) AS
       SELECT order_time, count(user_id) FROM sales GROUP BY order_time
       ```  
   
    In the above syntax `DMPROPERTIES` and `AS QUERY` are optional.
   
     - [X] Any interfaces changed?
       NO
     - [X] Any backward compatibility impacted?
       NO
     - [X] Document update required?
        Yes, need to add new syntax to document
     - [X] Testing done
            Testcases are added
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ravipesala/incubator-carbondata datamap-parser1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1481.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1481
   
----
commit 75faa7755fa3c493ea7cf9882187dca9425373b4
Author: ravipesala <[hidden email]>
Date:   2017-11-10T10:48:17Z

    Added create datamap parser and saved to schema file

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/966/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1581/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/990/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1607/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1000/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1617/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1007/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1624/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1023/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1641/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1025/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1643/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1029/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1647/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1032/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1481
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1650/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1481#discussion_r150479725
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DataMapSchema.java ---
    @@ -30,6 +30,8 @@
     
       private static final long serialVersionUID = 6577149126264181553L;
     
    +  private String dataMapName;
    --- End diff --
   
    please add comment, this name is used for what purpose?


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1481#discussion_r150479458
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java ---
    @@ -322,17 +322,22 @@
         for (DataMapSchema wrapperChildSchema : wrapperChildSchemaList) {
           org.apache.carbondata.format.DataMapSchema thriftChildSchema =
               new org.apache.carbondata.format.DataMapSchema();
    -      org.apache.carbondata.format.RelationIdentifier relationIdentifier =
    -          new org.apache.carbondata.format.RelationIdentifier();
    -      relationIdentifier
    -          .setDatabaseName(wrapperChildSchema.getRelationIdentifier().getDatabaseName());
    -      relationIdentifier.setTableName(wrapperChildSchema.getRelationIdentifier().getTableName());
    -      relationIdentifier.setTableId(wrapperChildSchema.getRelationIdentifier().getTableId());
    -      thriftChildSchema.setRelationIdentifire(relationIdentifier);
    +      if (wrapperChildSchema.getRelationIdentifier() != null) {
    +        org.apache.carbondata.format.RelationIdentifier relationIdentifier =
    +            new org.apache.carbondata.format.RelationIdentifier();
    +        relationIdentifier
    +            .setDatabaseName(wrapperChildSchema.getRelationIdentifier().getDatabaseName());
    --- End diff --
   
    move to previous line, move parameter to next line


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1481#discussion_r150480075
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchema.java ---
    @@ -255,21 +255,15 @@ public void readFields(DataInput in) throws IOException {
        * Below method will be used to build child schema object which will be stored in
        * parent table
        *
    -   * @param className
    -   * @param databaseName
    -   * @param queryString
    -   * @param queryType
    -   *
    -   * @return datamap schema
        */
    -  public DataMapSchema buildChildSchema(String className, String databaseName, String queryString,
    -      String queryType) {
    +  public DataMapSchema buildChildSchema(String dataMapName, String className, String databaseName,
    --- End diff --
   
    Is the dataMapName is for child schema? Please modify the parameter name or describe in function comment in line 255


---