GitHub user anubhav100 opened a pull request:
https://github.com/apache/carbondata/pull/1486 [CARBONDATA-1694] [BugFix] Resolved bug for Incorrect exception on presto CLI when a column is dropped from carbon **Steps to reproduce** : same as https://issues.apache.org/jira/browse/CARBONDATA-1694 **Reason:** table key still exists in carboncache it there is a change in metadatadirectory of carbon that change happens when ever we execute any alter table command on a table from carbon using thrift server **How To Verify This Pr*:* same as https://issues.apache.org/jira/browse/CARBONDATA-1694 **Testing Is Done Manually** : **Here Are Logs** 1.**created a table in carbondata** 0: jdbc:hive2://localhost:10000> create table carbontableforalter(id int,name string) stored by 'carbondata'; +---------+--+ | Result | +---------+--+ +---------+--+ No rows selected (0.11 seconds) 0: jdbc:hive2://localhost:10000> insert into carbontableforalter values(1,'anubhav'); +---------+--+ | Result | +---------+--+ +---------+--+ 2. **goes to presto cli and select it** presto:default> select * from carbontableforalter; id | name ----+--------- 1 | anubhav (1 row) Query 20171110_144215_00002_yykz4, FINISHED, 1 node Splits: 17 total, 17 done (100.00%) 0:00 [1 rows, 4KB] [3 rows/s, 14.3KB/s 3.**goes back to carbon and drop a column using beeline** 0: jdbc:hive2://localhost:10000> alter table carbontableforalter drop columns(id); +---------+--+ | Result | +---------+--+ +---------+--+ No rows selected (0.155 seconds) 0: jdbc:hive2://localhost:10000> select * from carbontableforalter; +----------+--+ | name | +----------+--+ | anubhav | +----------+--+ 1 row selected (0.158 seconds) 4.**goes back to presto cli to select the table** presto:default> select * from carbontableforalter; name --------- anubhav (1 row) Query 20171110_144232_00003_yykz4, FINISHED, 1 node Splits: 17 total, 17 done (100.00%) 0:00 [1 rows, 4KB] [4 rows/s, 16.9KB/s] You can merge this pull request into a Git repository by running: $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-1694 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1486.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1486 ---- commit 34054c84cb10114b0b10f674e6f75f5b28129b2d Author: anubhav100 <[hidden email]> Date: 2017-11-10T14:17:25Z resolved bug for Incorrect exception on presto CLI while executing select query after applying alter drop column query on a table ---- --- |
Github user anubhav100 commented on the issue:
https://github.com/apache/carbondata/pull/1486 @chenliang613 can you please review this pr? --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1486 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/983/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1486 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1601/ --- |
In reply to this post by qiuchenjian-2
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1486 verified, LGTM. Thanks for your good contribution. --- |
In reply to this post by qiuchenjian-2
|
Free forum by Nabble | Edit this page |