[GitHub] carbondata pull request #1503: Branch 1.1

[qiuchenjian-2]

GitHub user sehriff opened a pull request:

    https://github.com/apache/carbondata/pull/1503

    Branch 1.1

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sehriff/carbondata branch-1.1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1503
   
----
commit fcf4b6fad6faeebe096d468d741d670001e59df8
Author: sehriff <[hidden email]>
Date:   2017-11-16T07:58:58Z

    Create TableHeadCountReader

commit 94e1aed981290c4804dccacda4e9ef3c7b82bb55
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:05:56Z

    Update and rename TableHeadCountReader to TableHeaderCountReader

commit f1e94d2ef08711720a45167f68d41a10ae64e9ed
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:22:49Z

    Create HiveTableHeaderCountScanExec.scala

commit 5c844ca44489ed11823aeb0ea3fb996479dbd024
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:23:33Z

    Rename TableHeaderCountReader to TableHeaderCountReader.scala

commit 29f736ee3a9bee34886beb4f2c6bdf970ac99fca
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:24:02Z

    Create HiveStrategies.scala

commit 884f474b460e014013f2e845b359f8a2f5ad0c96
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:25:20Z

    Create CarbonHiveSessionState.scala

commit 8900d9c8981d0372f4c020cc66f775467793670a
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:26:18Z

    Update CarbonSessionState.scala

----


---

[qiuchenjian-2]

Github user sehriff commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    Support `skip.header.line.count` option for Hive Table in Carbon


---

[qiuchenjian-2]

Github user sehriff commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    refering to PR https://github.com/apache/spark/pull/14638/files for hive table scan logic code


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1172/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1749/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1503#discussion_r151638177
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonHiveSessionState.scala ---
    @@ -0,0 +1,120 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.hive
    +
    +import org.apache.spark.sql._
    +import org.apache.spark.sql.catalyst.analysis.Analyzer
    +import org.apache.spark.sql.execution.SparkPlanner
    +import org.apache.spark.sql.execution.datasources._
    +
    +
    +/**
    + * A class that holds all session-specific state in a given [[SparkSession]] backed by Hive.
    + */
    +private[hive] class CarbonHiveSessionState(sparkSession: SparkSession)
    --- End diff --
   
    Can you just add the necessary part to support `skip.header.line.count` option without copying the whole class from spark?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1310/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    @sehriff  please squash all commits to one commit


---

[qiuchenjian-2]

Github user sehriff closed the pull request at:

    https://github.com/apache/carbondata/pull/1503


---

[qiuchenjian-2]

GitHub user sehriff reopened a pull request:

    https://github.com/apache/carbondata/pull/1503

    [CARBONDATA-1730] Support skip.header.line.count option for Hive Table in Carbon

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [ ] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sehriff/carbondata branch-1.1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1503
   
----
commit fcf4b6fad6faeebe096d468d741d670001e59df8
Author: sehriff <[hidden email]>
Date:   2017-11-16T07:58:58Z

    Create TableHeadCountReader

commit 94e1aed981290c4804dccacda4e9ef3c7b82bb55
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:05:56Z

    Update and rename TableHeadCountReader to TableHeaderCountReader

commit f1e94d2ef08711720a45167f68d41a10ae64e9ed
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:22:49Z

    Create HiveTableHeaderCountScanExec.scala

commit 5c844ca44489ed11823aeb0ea3fb996479dbd024
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:23:33Z

    Rename TableHeaderCountReader to TableHeaderCountReader.scala

commit 29f736ee3a9bee34886beb4f2c6bdf970ac99fca
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:24:02Z

    Create HiveStrategies.scala

commit 884f474b460e014013f2e845b359f8a2f5ad0c96
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:25:20Z

    Create CarbonHiveSessionState.scala

commit 8900d9c8981d0372f4c020cc66f775467793670a
Author: sehriff <[hidden email]>
Date:   2017-11-16T08:26:18Z

    Update CarbonSessionState.scala

commit 43176e9ef6ead45ea91fac8ca1966123da299018
Author: sehriff <[hidden email]>
Date:   2017-11-20T08:38:36Z

    Update CarbonHiveSessionState.scala

----


---

[qiuchenjian-2]

Github user sehriff closed the pull request at:

    https://github.com/apache/carbondata/pull/1503


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1872/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1503
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1453/



---