[GitHub] carbondata pull request #1511: [CARBONDATA-1741] Remove AKSK in log when sav...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1511: [CARBONDATA-1741] Remove AKSK in log when sav...

qiuchenjian-2
GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1511

    [CARBONDATA-1741] Remove AKSK in log when saving to S3

    In order to provide better security, AKSK credential information should be removed in log
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
    No testcase is added
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    MR24

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata removeaksk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1511
   
----
commit 09ff30688fe84c199fb86b92b9547c859e05a75c
Author: Jacky Li <[hidden email]>
Date:   2017-11-16T09:27:21Z

    add s3 in filefactory

commit 8d31b0974071bb7cd8ad72aa58990b9f2621b8a1
Author: Jacky Li <[hidden email]>
Date:   2017-11-16T11:41:19Z

    remove unnecessary path

commit 5a7008e0691daff9bad3c8bf707d0592500a1f24
Author: Jacky Li <[hidden email]>
Date:   2017-11-16T12:56:55Z

    clean CarbonEnv

commit aeee0e5f7df61f1add1dca30be0722aab0a8d2dd
Author: Jacky Li <[hidden email]>
Date:   2017-11-16T13:23:22Z

    remove AKSK in log

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1511: [CARBONDATA-1741] Remove AKSK in log when saving to ...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1511
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1184/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1511: [CARBONDATA-1741] Remove AKSK in log when saving to ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1511
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1216/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1511: [CARBONDATA-1741] Remove AKSK in log when saving to ...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1511
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1511: [CARBONDATA-1741] Remove AKSK in log when sav...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1511


---