[GitHub] carbondata pull request #1525: [CARBONDATA-1751] Make the type of exception ...

[qiuchenjian-2]

GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1525

    [CARBONDATA-1751] Make the type of exception and message correctly

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
        change old test cases to adapt changed massage
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    MR55


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata msgYaDong

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1525
   
----
commit 80ea7c95b00680c43fd8d16f5aa51a30311a8930
Author: xubo245 <[hidden email]>
Date:   2017-11-17T14:36:46Z

    [CARBONDATA-1751] Make the type of exception and message correctly

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1235/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1255/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1256/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1258/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1525#discussion_r151831251
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/AlterTableCompactionCommand.scala ---
    @@ -87,8 +88,10 @@ case class AlterTableCompactionCommand(
         } catch {
           case e: Exception =>
             if (null != e.getMessage) {
    +          // TODO: We should modify it when we support compaction later.
               sys.error(s"Compaction failed. Please check logs for more info. ${ e.getMessage }")
    --- End diff --
   
    Why not change this also?


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1265/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1268/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Please review it @jackylk


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1283/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1284/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    I have fixed conflicts, please review it @jackylk


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1302/



---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1525#discussion_r151911377
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
    @@ -18,12 +18,10 @@
     package org.apache.spark.carbondata
     
     import scala.collection.mutable
    -
     import org.apache.spark.sql.common.util.Spark2QueryTest
     import org.apache.spark.sql.types._
    -import org.apache.spark.sql.{Row, SaveMode}
    +import org.apache.spark.sql.{AnalysisException, Row, SaveMode}
     import org.scalatest.BeforeAndAfterAll
    -
    --- End diff --
   
    Suggest keep this space line


---

[qiuchenjian-2]

Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1525#discussion_r151911286
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
    @@ -18,12 +18,10 @@
     package org.apache.spark.carbondata
     
     import scala.collection.mutable
    -
    --- End diff --
   
    Suggest keep this space line


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1525#discussion_r151912577
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
    @@ -18,12 +18,10 @@
     package org.apache.spark.carbondata
     
     import scala.collection.mutable
    -
    --- End diff --
   
    OK, Done


---

[qiuchenjian-2]

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1525#discussion_r151912584
 
    --- Diff: integration/spark2/src/test/scala/org/apache/spark/carbondata/CarbonDataSourceSuite.scala ---
    @@ -18,12 +18,10 @@
     package org.apache.spark.carbondata
     
     import scala.collection.mutable
    -
     import org.apache.spark.sql.common.util.Spark2QueryTest
     import org.apache.spark.sql.types._
    -import org.apache.spark.sql.{Row, SaveMode}
    +import org.apache.spark.sql.{AnalysisException, Row, SaveMode}
     import org.scalatest.BeforeAndAfterAll
    -
    --- End diff --
   
    OK, Done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1306/



---

[qiuchenjian-2]

Github user xubo245 commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    Erlu Chen and Yadong Qi have reivewed this PR, please review it again @jackylk


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1525
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1771/



---