[GitHub] carbondata pull request #1528: [WIP][CARBONDATA-1752] There are some scalast...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1528: [WIP][CARBONDATA-1752] There are some scalast...

qiuchenjian-2
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1528

    [WIP][CARBONDATA-1752] There are some scalastyle error should be optimized  in CarbonData

    There are some scalastyle error should be optimized in CarbonData, including removing useless import, optimizing method definition and so on
   
    We should add it into scala style check.
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [ ] Any interfaces changed?
     No
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
    No
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata fixStyle2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1528
   
----
commit 3f8a6d11a0e53ccd0e76ea16ef4167e6b04b9678
Author: xubo245 <[hidden email]>
Date:   2017-11-18T03:46:59Z

    [CARBONDATA-1752] There are some scalastyle error should be optimized in CarbonData

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1528: [WIP][CARBONDATA-1752] There are some scalastyle err...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1528
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1257/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1528: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1528
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1270/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1528: [CARBONDATA-1752] There are some scalastyle error sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1528
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1528: [CARBONDATA-1752] There are some scalastyle e...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1528


---