[GitHub] carbondata pull request #1549: [CARBONDATA-1793] Insert / update is allowing...

[qiuchenjian-2]

GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1549

    [CARBONDATA-1793] Insert / update is allowing more than 32000 characters for String column

    Load is restricted to 32000 characters per column. But insert and update are allowing more than 32000 characters. Behavior should be consistent.
   
    Solution:
    Restrict insert and update to 32000 characters
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [X] Testing done
            UT Added
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata 32000char

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1549
   
----
commit 41f1428b49cce37a72d574c797afef469f9c67bb
Author: dhatchayani <[hidden email]>
Date:   2017-11-22T06:13:49Z

    [CARBONDATA-1793] Insert / update is allowing more than 32000 characters for String column

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1358/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1815/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1818/



---

[qiuchenjian-2]

Github user dhatchayani commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1821/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1391/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1549
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1549


---