[GitHub] carbondata pull request #1553: [CARBONDATA-1797] Segment_Index compaction sh...

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1553: [CARBONDATA-1797] Segment_Index compaction sh...

qiuchenjian-2
GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1553

    [CARBONDATA-1797] Segment_Index compaction should take compaction lock to support concurrent scenarios better

    SEGMENT_INDEX compaction is not taking compaction lock. While concurrent operation, compaction may be successful but the output may not be as expected.
   
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
   
     - [x] Testing done
            Manual testing
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata compaction_lock

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1553
   
----

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1553: [CARBONDATA-1797] Segment_Index compaction should ta...

qiuchenjian-2
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1553
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1369/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1553: [CARBONDATA-1797] Segment_Index compaction should ta...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1553
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1825/



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata issue #1553: [CARBONDATA-1797] Segment_Index compaction should ta...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1553
 
    LGTM


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] carbondata pull request #1553: [CARBONDATA-1797] Segment_Index compaction sh...

qiuchenjian-2
In reply to this post by qiuchenjian-2
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1553


---