[GitHub] carbondata pull request #1556: [CARBONDATA-1770] Updated documentaion for da...

[qiuchenjian-2]

GitHub user vandana7 opened a pull request:

    https://github.com/apache/carbondata/pull/1556

    [CARBONDATA-1770] Updated documentaion for data-management-on-carbondata.md and useful-tips-on-carbondata.md

    While reviewing PR #1534, still there exist some changes which needs to be fixed. I have done those fixes in this PR, please review.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vandana7/incubator-carbondata document_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1556
   
----
commit 6b24c4fccda9be8b089cff2e7d0fdcbcab00d557
Author: vandana <[hidden email]>
Date:   2017-11-23T06:51:20Z

    some remaing fix

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1556
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1386/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1556
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1833/



---

[qiuchenjian-2]

Github user chenliang613 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1556#discussion_r152738129
 
    --- Diff: docs/data-management-on-carbondata.md ---
    @@ -294,11 +294,11 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
         ```
         NOTE: ALL_DICTIONARY_PATH and COLUMNDICT can't be used together.
         
    -  - **DATEFORMAT:** Date format for specified column.
    +  - **DATEFORMAT/TIMESTAMPFORMAT:** Date and Timestamp format for specified column.
     
         ```
    -    OPTIONS('DATEFORMAT'='column1:dateFormat1, column2:dateFormat2')
    -    ```
    +    OPTIONS('dateformat' = 'yyyy-MM-dd','timestampformat'='yyyy/MM/dd HH:mm:ss')
    --- End diff --
   
    please use uppercase for "dateformat,timestampformat".


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1556
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1388/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1556
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1390/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1556
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1837/



---

[qiuchenjian-2]

Github user chenliang613 commented on the issue:

    https://github.com/apache/carbondata/pull/1556
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1556


---