[GitHub] carbondata pull request #1576: [CARBONDATA-1817] Reject creating datamap on ...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1576

    [CARBONDATA-1817] Reject creating datamap on streaming table

    Since streaming segment does not support building index and pre-aggregate yet, so streaming table should not support create datamap operation
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
    One testcase added
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata streaming_donot_agg

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1576.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1576
   
----
commit 16c843395c37220681c9aeeaa0063740ed55c537
Author: Jacky Li <[hidden email]>
Date:   2017-11-27T08:48:09Z

    add AtomicRunnableCommand

commit a77183d0d08c11a4de4dd4c71eaf742ecef12b68
Author: Jacky Li <[hidden email]>
Date:   2017-11-27T08:57:56Z

    fix comment

commit d0a9a4ab8b2b163d9ec215debedd74f7207adf45
Author: Jacky Li <[hidden email]>
Date:   2017-11-27T11:00:34Z

    fix comment

commit ae982596c56eb5079db83e4dff2a20a7448b3491
Author: Jacky Li <[hidden email]>
Date:   2017-11-27T11:07:29Z

    fix comment

commit 8cc59e3dbe9bf721dbfcee753bf3b4881ac5062c
Author: Jacky Li <[hidden email]>
Date:   2017-11-27T11:30:44Z

    fix style

commit 9999e724ac4086998fee081890abf75c0e88d2b5
Author: Jacky Li <[hidden email]>
Date:   2017-11-27T11:24:09Z

    block create datamap on streaming table

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1495/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1501/



---

[qiuchenjian-2]

Github user kumarvishal09 commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    @jackylk Changes is not only related to blocking the data map creation. Its better to raise changes done for refactoring in different pr


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1912/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    @kumarvishal09 This PR is on top of #1573 , so it contains commit on top of that. I will rebase after #1573 is merged


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1566/



---

[qiuchenjian-2]

Github user QiangCai commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1576


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1576
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1965/



---