GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/carbondata/pull/1583 [CARBONDATA-1822][Spark-Integration] Support DDL to register the CarbonData table from existing carbon table data Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? Added new DDL command to register carbon tables using existing carbon table data/schema. - [ ] Any backward compatibility impacted? No - [ ] Document update required? Yes - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. Yes Added new test case to validate the register of normal table and aggregate table. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mohammadshahidkhan/incubator-carbondata register_carbon Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/1583.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1583 ---- commit a23aadeb75a68f9cc3fd5e18eb5e109aa66a1388 Author: mohammadshahidkhan <[hidden email]> Date: 2017-11-23T14:32:14Z [CARBONDATA-1822][Spark-Integration] Support DDL to register the CarbonData table from existing carbon table data ---- --- |
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1534/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1938/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1545/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1946/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1550/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1551/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1950/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1560/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1562/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1959/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1961/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1595/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1991/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1605/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1608/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2000/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1583 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2002/ --- |
In reply to this post by qiuchenjian-2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1583 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1614/ --- |
In reply to this post by qiuchenjian-2
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1583#discussion_r154118475 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/RefreshCarbonTableCommand.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command.management + +import java.util + +import scala.collection.JavaConverters._ + +import org.apache.spark.sql._ +import org.apache.spark.sql.execution.command.MetadataCommand +import org.apache.spark.sql.util.CarbonException + +import org.apache.carbondata.common.logging.{LogService, LogServiceFactory} +import org.apache.carbondata.core.constants.CarbonCommonConstants +import org.apache.carbondata.core.datastore.impl.FileFactory +import org.apache.carbondata.core.locks.{ICarbonLock, LockUsage} +import org.apache.carbondata.core.metadata.{AbsoluteTableIdentifier, CarbonTableIdentifier} +import org.apache.carbondata.core.metadata.converter.ThriftWrapperSchemaConverterImpl +import org.apache.carbondata.core.metadata.schema.table.{DataMapSchema, TableInfo} +import org.apache.carbondata.core.metadata.schema.table.column.ColumnSchema +import org.apache.carbondata.core.util.CarbonProperties +import org.apache.carbondata.core.util.path.CarbonStorePath +import org.apache.carbondata.events.{CreateTablePreExecutionEvent, OperationContext, OperationListenerBus, RefreshTablePostExecutionEvent, RefreshTablePreExecutionEvent} +import org.apache.carbondata.spark.util.CommonUtil + +/** + * Command to register carbon table from existing carbon table data + */ +case class RefreshCarbonTableCommand( + dbName: Option[String], + tableName: String) + extends MetadataCommand { + val LOGGER: LogService = + LogServiceFactory.getLogService(this.getClass.getName) + + override def processMetadata(sparkSession: SparkSession): Seq[Row] = { + val metaStore = CarbonEnv.getInstance(sparkSession).carbonMetastore + val databaseName = GetDB.getDatabaseName(dbName, sparkSession) + val databaseLocation = GetDB.getDatabaseLocation(databaseName, sparkSession, + CarbonProperties.getStorePath) + // Steps + // 1. get table path + // 2. perform the below steps + // 2.1 check if the table already register with hive then ignore and continue with the next + // schema + // 2.2 register the table with the hive check if the table being registered has aggregate table + // then do the below steps + // 2.2.1 validate that all the aggregate tables are copied at the store location. + // 2.2.2 Register the aggregate tables + val locksToBeAcquired = List(LockUsage.METADATA_LOCK, LockUsage.DROP_TABLE_LOCK) + var locks = List.empty[ICarbonLock] + try { + val tablePath = databaseLocation + CarbonCommonConstants.FILE_SEPARATOR + tableName + val absoluteTableIdentifier = AbsoluteTableIdentifier.from(tablePath, databaseName, tableName) + locks = CommonUtil.acquireLock(locksToBeAcquired, absoluteTableIdentifier) + // 2.1 check if the table already register with hive then ignore and continue with the next + // schema + if (!sparkSession.sessionState.catalog.listTables(databaseName) + .exists(_.table.equalsIgnoreCase(tableName))) { + val carbonTablePath = CarbonStorePath.getCarbonTablePath(absoluteTableIdentifier) --- End diff -- Please move reading of TableInfo using tablePath to the CarbonMetaStore --- |
Free forum by Nabble | Edit this page |