Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1584#discussion_r158615665
--- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/CarbonS3FileSystem.java ---
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *
http://www.apache.org/licenses/LICENSE-2.0 + *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.carbondata.core.datastore.impl;
+
+import java.io.BufferedOutputStream;
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.net.URI;
+import static java.nio.file.Files.createDirectories;
+import static java.nio.file.Files.createTempFile;
+import static java.util.Objects.requireNonNull;
+
+import org.apache.carbondata.core.util.CarbonProperties;
+import static org.apache.carbondata.core.constants.CarbonCommonConstants.PATH_SEPARATOR;
+import static org.apache.carbondata.core.constants.CarbonCommonConstants.S3_STAGING_DIRECTORY;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.permission.FsPermission;
+import org.apache.hadoop.fs.s3a.S3AFileSystem;
+import org.apache.hadoop.util.Progressable;
+
+import static org.apache.hadoop.fs.s3a.Constants.ACCESS_KEY;
+import static org.apache.hadoop.fs.s3a.Constants.MIN_MULTIPART_THRESHOLD;
+import static org.apache.hadoop.fs.s3a.Constants.MULTIPART_SIZE;
+import static org.apache.hadoop.fs.s3a.Constants.SECRET_KEY;
+
+public class CarbonS3FileSystem extends S3AFileSystem {
+
+ private URI uri;
+ private File stagingDirectory;
+
+ @Override public void initialize(URI uri, Configuration conf) throws IOException {
+ requireNonNull(uri, "uri is null");
+ requireNonNull(conf, "conf is null");
+ setConf(conf);
+ this.uri = URI.create(uri.getScheme() + "://" + uri.getAuthority());
+ new Path(PATH_SEPARATOR).makeQualified(this.uri, new Path(PATH_SEPARATOR));
+
+ CarbonProperties defaults = CarbonProperties.getInstance();
+ if (defaults.getProperty(ACCESS_KEY) != null) {
--- End diff --
no need to support AKSK configuration in carbon.properties.
---
Locked
