[GitHub] carbondata pull request #1603: [CARBONDATA-1844] Add tablePath support when ...

[qiuchenjian-2]

GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1603

    [CARBONDATA-1844] Add tablePath support when creating table

    User should be able to specify table path when creating table. This PR implement it.
   
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    Yes
     - [X] Testing done
     Testcase added
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata tablepath

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1603
   
----
commit 4b960eddc0abeb32bccf0447b254718e14bd09cb
Author: Jacky Li <[hidden email]>
Date:   2017-12-02T19:04:03Z

    add tablePath

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2032/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2033/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1644/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2034/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1645/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2035/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1646/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2037/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1648/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2038/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1649/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2039/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1651/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1653/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2041/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1603
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1654/



---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1603#discussion_r154527161
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadDataWithHiveSyntaxDefaultFormat.scala ---
    @@ -687,6 +688,48 @@ class TestLoadDataWithHiveSyntaxDefaultFormat extends QueryTest with BeforeAndAf
         checkAnswer(sql("select salary from double_test limit 1"),Row(7.756787654567891E23))
       }
     
    +  test("test table with specified table path") {
    --- End diff --
   
    these are new testcase


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1603#discussion_r154527695
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableInfo.java ---
    @@ -68,17 +70,10 @@
        */
       private long lastUpdatedTime;
     
    -  /**
    -   * metadata file path (check if it is really required )
    -   */
    -  private String metaDataFilepath;
    -
    -  /**
    -   * store location
    -   */
    +  @Obsolete
    --- End diff --
   
    Why it is obsolete ? is there any other way user can get tablePath?


---