[GitHub] carbondata pull request #1608: [CARBONDATA-1761]do not change status of segm...

[qiuchenjian-2]

GitHub user akashrn5 opened a pull request:

    https://github.com/apache/carbondata/pull/1608

    [CARBONDATA-1761]do not change status of segment to marked for delete if it is in progress

    do not change status of segment to marked for delete if it is in progress
   
    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [*] Any interfaces changed?
     NA
     - [*] Any backward compatibility impacted?
     NA
     - [*] Document update required?
    NA
     - [*] Testing done
            tested in local
           
     - [*] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    NA


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/akashrn5/incubator-carbondata delete

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1608
   
----
commit de63d8c843a7860f49d3e5b5627aceee1332f37d
Author: akashrn5 <[hidden email]>
Date:   2017-12-04T12:31:18Z

    do not change status of segment to marked for delete if it is in progress

----


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2067/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/409/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1681/



---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1608#discussion_r154835950
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ---
    @@ -493,6 +493,19 @@ public static void writeLoadDetailsIntoFile(String dataLoadLocation,
                 invalidLoadIds.add(loadId);
                 return invalidLoadIds;
               }
    +          // if the segment status is in progress then no need to delete that.
    +          if (SegmentStatus.INSERT_IN_PROGRESS == loadMetadata.getSegmentStatus()) {
    +            LOG.error("Cannot delete the Segment which is In Progress. Segment is " + loadId);
    --- End diff --
   
    Please rephrase the sentence
    `"Cannot delete the segemnt "+ loadId +" which is load in progress" `


---

[qiuchenjian-2]

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1608#discussion_r154835999
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java ---
    @@ -493,6 +493,19 @@ public static void writeLoadDetailsIntoFile(String dataLoadLocation,
                 invalidLoadIds.add(loadId);
                 return invalidLoadIds;
               }
    +          // if the segment status is in progress then no need to delete that.
    +          if (SegmentStatus.INSERT_IN_PROGRESS == loadMetadata.getSegmentStatus()) {
    +            LOG.error("Cannot delete the Segment which is In Progress. Segment is " + loadId);
    +            invalidLoadIds.add(loadId);
    +            return invalidLoadIds;
    +          }
    +          // if the segment status is overwrite in progress, then no need to delete that.
    +          if (SegmentStatus.INSERT_OVERWRITE_IN_PROGRESS == loadMetadata.getSegmentStatus()) {
    +            LOG.error("Cannot delete the Segment which is Overwrite In Progress. " +
    --- End diff --
   
    Please rephrase the sentence
    `"Cannot delete the segemnt "+ loadId +" which is load overwrite in progress" `


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    @ravipesala handled comments please review


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/435/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/436/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2090/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1706/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    retest this please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    retest sdv please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/458/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1725/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/463/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2107/



---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Please combine this PR with #1610, it is better to keep all rejecting logic in one PR


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1608
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1731/



---