[GitHub] carbondata pull request #1610: [CARBONDATA-1879]do not drop the table if the...

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1708/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    @ravipesala i have added test case for both scenario


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/448/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1715/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2098/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2099/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    @akashrn5 Please fix the SDV


---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/459/



---

[qiuchenjian-2]

Github user akashrn5 commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    retest sdv please


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1610#discussion_r154979231
 
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/concurrent/TestLoadTableConcurrentScenario.scala ---
    @@ -0,0 +1,61 @@
    +package org.apache.carbondata.spark.testsuite.concurrent
    --- End diff --
   
    license header needed


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1610#discussion_r154979407
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala ---
    @@ -71,6 +73,10 @@ case class CarbonDropTableCommand(
               ifExistsSet,
               sparkSession)
           OperationListenerBus.getInstance.fireEvent(dropTablePreEvent, operationContext)
    +      if (SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)) {
    +        throw new AnalysisException(s"Cannot drop table, load or insert overwrite is " +
    --- End diff --
   
    use operationNotAllowed


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1610#discussion_r154979725
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala ---
    @@ -83,6 +85,11 @@ private[sql] case class CarbonAlterTableRenameCommand(
               sparkSession)
           carbonTable = metastore.lookupRelation(Some(oldDatabaseName), oldTableName)(sparkSession)
             .asInstanceOf[CarbonRelation].carbonTable
    +      // if any load is in progress for table, do not allow rename table
    +      if (SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)) {
    +        throw new AnalysisException(s"alter rename failed, load, insert or insert " +
    --- End diff --
   
    use operationNotAllowed


---

[qiuchenjian-2]

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1610#discussion_r154982129
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala ---
    @@ -83,6 +85,11 @@ private[sql] case class CarbonAlterTableRenameCommand(
               sparkSession)
           carbonTable = metastore.lookupRelation(Some(oldDatabaseName), oldTableName)(sparkSession)
             .asInstanceOf[CarbonRelation].carbonTable
    +      // if any load is in progress for table, do not allow rename table
    +      if (SegmentStatusManager.checkIfAnyLoadInProgressForTable(carbonTable)) {
    +        throw new AnalysisException(s"alter rename failed, load, insert or insert " +
    --- End diff --
   
    Since this PR not just modify for drop table command, can you add the reject logic in all impacted command. I think  all commands that involves metadata modification is not allowed, right? @ravipesala please have a look


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/473/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1729/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/477/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1738/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2112/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1610
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2121/



---