[GitHub] carbondata pull request #1614: [CARBONDATA-1592] Changed Event params

[qiuchenjian-2]

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1614#discussion_r155414167
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala ---
    @@ -131,40 +135,44 @@ case class AlterTableRenameAbortEvent(carbonTable: CarbonTable,
     
     
     /**
    - *
    + * Class for handling pre compaction operations
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1614#discussion_r155468332
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala ---
    @@ -131,40 +135,49 @@ case class AlterTableRenameAbortEvent(carbonTable: CarbonTable,
     
     
     /**
    + * Event for handling pre compaction operations, lister has to implement this event on pre execution
      *
    + * @param sparkSession
      * @param carbonTable
    - * @param carbonLoadModel
    - * @param mergedLoadName
    - * @param sQLContext
      */
    -case class AlterTableCompactionPreEvent(sparkSession: SparkSession, carbonTable: CarbonTable,
    -    carbonLoadModel: CarbonLoadModel,
    -    mergedLoadName: String,
    -    sQLContext: SQLContext) extends Event with AlterTableCompactionEventInfo
    +case class AlterTableCompactionPreEvent(sparkSession: SparkSession, carbonTable: CarbonTable)
    --- End diff --
   
    ok


---

[qiuchenjian-2]

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1614#discussion_r155157176
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/Events.scala ---
    @@ -93,12 +93,20 @@ trait AlterTableAddColumnEventInfo {
     /**
      * event for alter_table_rename
      */
    -trait AlterTableCompactionEventInfo {
    +trait AlterTableCompactionStatusUpdateEventInfo {
    --- End diff --
   
   
    +    loadsToMerge: util.List[LoadMetadataDetails],
     +    compactionType: CompactionType,
     +    sQLContext: SQLContext)
     +  extends Event with AlterTableCompactionStatusUpdateEventInfo


---

[qiuchenjian-2]

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1614#discussion_r155414323
 
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/Events.scala ---
    @@ -93,12 +93,20 @@ trait AlterTableAddColumnEventInfo {
     /**
      * event for alter_table_rename
      */
    -trait AlterTableCompactionEventInfo {
    +trait AlterTableCompactionStatusUpdateEventInfo {
       val carbonTable: CarbonTable
       val carbonLoadModel: CarbonLoadModel
       val mergedLoadName: String
     }
     
    +/**
    + * event for alter_table_compaction
    + */
    +trait AlterTableCompactionEventInfo {
    --- End diff --
   
    This trait we are using in both pre & post compaction events , these two events are required for decouple purpose


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/567/



---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    LGTM


---

[qiuchenjian-2]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1614#discussion_r155496669
 
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -492,6 +492,12 @@ object CarbonDataRDDFactory {
             throw new Exception("No Data to load")
           }
           writeDictionary(carbonLoadModel, result, writeAll = false)
    +      val loadTablePreStatusUpdateEvent: LoadTablePreStatusUpdateEvent =
    --- End diff --
   
    Trigger should pass operationContext


---

[qiuchenjian-2]

Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1614#discussion_r155518002
 
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala ---
    @@ -492,6 +492,12 @@ object CarbonDataRDDFactory {
             throw new Exception("No Data to load")
           }
           writeDictionary(carbonLoadModel, result, writeAll = false)
    +      val loadTablePreStatusUpdateEvent: LoadTablePreStatusUpdateEvent =
    --- End diff --
   
    done


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/580/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1815/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/585/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1823/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1830/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/602/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2200/



---

[qiuchenjian-2]

Github user gvramana commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1614


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1833/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1614
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/605/



---