[GitHub] carbondata pull request #1622: Refactored code to skip single-pass for first...

[qiuchenjian-2]

GitHub user SangeetaGulia opened a pull request:

    https://github.com/apache/carbondata/pull/1622

    Refactored code to skip single-pass for first data load

    Be sure to do all of the following checklist to help us incorporate
    your contribution quickly and easily:
   
     - [x] Any interfaces changed? (N/A)
     
     - [x] Any backward compatibility impacted? (N/A)
     
     - [x] Document update required? (N/A)
   
     - [x] Testing done
            Please provide details on
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
     
     - [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    (N/A)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SangeetaGulia/incubator-carbondata CARBONDATA-1865

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1622
   
----
commit 3e3100b64b89e54e95a15306fe8d7b40f1ceee01
Author: SangeetaGulia <[hidden email]>
Date:   2017-12-06T09:48:00Z

    Refactored code to skip single-pass for first data load

----


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/496/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1759/



---

[qiuchenjian-2]

Github user SangeetaGulia commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    retest this please


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/501/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1764/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2142/



---

[qiuchenjian-2]

Github user kunal642 commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    retest sdv please


---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2213/



---

[qiuchenjian-2]

Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1622#discussion_r156304089
 
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala ---
    @@ -160,7 +160,7 @@ case class CarbonLoadDataCommand(
             if (isOverwriteTable) {
               LOGGER.info(s"Overwrite of carbon table with $dbName.$tableName is in progress")
             }
    -        if (carbonLoadModel.getLoadMetadataDetails.isEmpty && carbonLoadModel.getUseOnePass &&
    +        if (carbonLoadModel.getLoadMetadataDetails.size() == 1 && carbonLoadModel.getUseOnePass &&
    --- End diff --
   
    This if condition can be remove as the high_cardinality check has been removed.
    @manishgupta88 Please suggest


---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/669/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Failed  with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1898/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1901/



---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/672/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2235/



---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2239/



---

[qiuchenjian-2]

Github user manishgupta88 commented on the issue:

    https://github.com/apache/carbondata/pull/1622
 
    LGTM


---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1622


---